Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi…

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/plugins/plugin_utils.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/policy_indicator_localized_strings_provider.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/locale_settings.h"
 #include "components/autofill/core/browser/payments/payments_service_url.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/google/core/browser/google_util.h"
@@ skipping 1254 matching lines @@
       {"searchEnginesEdit", IDS_SETTINGS_SEARCH_ENGINES_EDIT},
       {"searchEnginesRemoveFromList",
        IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST},
       {"searchEnginesManageExtension",
        IDS_SETTINGS_SEARCH_ENGINES_MANAGE_EXTENSION},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 }
 
-void AddSiteSettingsStrings(content::WebUIDataSource* html_source) {
+void AddSiteSettingsStrings(content::WebUIDataSource* html_source,
+                            Profile* profile) {
   LocalizedString localized_strings[] = {
       {"addSiteHeader", IDS_SETTINGS_ADD_SITE_HEADER},
       {"addSiteLink", IDS_SETTINGS_ADD_SITE_LINK},
       {"addSite", IDS_SETTINGS_ADD_SITE},
       {"cookieAppCache", IDS_COOKIES_APPLICATION_CACHE},
       {"cookieCacheStorage", IDS_COOKIES_CACHE_STORAGE},
       {"cookieChannelId", IDS_COOKIES_CHANNEL_ID},
       {"cookieDatabaseStorage", IDS_COOKIES_DATABASE_STORAGE},
       {"cookieFileSystem", IDS_COOKIES_FILE_SYSTEM},
       {"cookieFlashLso", IDS_COOKIES_FLASH_LSO},
@@ skipping 164 matching lines @@
       {"adobeFlashStorage", IDS_SETTINGS_SITE_SETTINGS_ADOBE_FLASH_SETTINGS},
       {"learnMore", IDS_SETTINGS_SITE_SETTINGS_LEARN_MORE},
       {"incognitoSite", IDS_SETTINGS_SITE_SETTINGS_INCOGNITO},
       {"incognitoSiteOnly", IDS_SETTINGS_SITE_SETTINGS_INCOGNITO_ONLY},
       {"embeddedIncognitoSite", IDS_SETTINGS_SITE_SETTINGS_INCOGNITO_EMBEDDED},
       {"siteSettingsSiteDetails", IDS_SETTINGS_SITE_DETAILS},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 
-  if (base::FeatureList::IsEnabled(features::kPreferHtmlOverPlugins)) {
+  if (PluginUtils::ShouldPreferHtmlOverPlugins(
+          HostContentSettingsMapFactory::GetForProfile(profile))) {
     LocalizedString flash_strings[] = {
         {"siteSettingsFlashAskBefore",
          IDS_SETTINGS_SITE_SETTINGS_FLASH_ASK_BEFORE_RUNNING},
         {"siteSettingsFlashAskBeforeSubtitle",
          IDS_SETTINGS_SITE_SETTINGS_FLASH_ASK_BEFORE_RUNNING_SUBTITLE},
     };
     AddLocalizedStringsBulk(html_source, flash_strings,
                             arraysize(flash_strings));
   } else {
     LocalizedString flash_strings[] = {
@@ skipping 196 matching lines @@
 #endif
   AddOnStartupStrings(html_source);
   AddPasswordsAndFormsStrings(html_source);
   AddPeopleStrings(html_source);
   AddPrintingStrings(html_source);
   AddPrivacyStrings(html_source);
   AddResetStrings(html_source);
   AddSearchEnginesStrings(html_source);
   AddSearchInSettingsStrings(html_source);
   AddSearchStrings(html_source);
-  AddSiteSettingsStrings(html_source);
+  AddSiteSettingsStrings(html_source, profile);
 #if !defined(OS_CHROMEOS)
   AddSystemStrings(html_source);
 #endif
   AddUsersStrings(html_source);
   AddWebContentStrings(html_source);
 
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings