Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2408603002: DevTools: disable smoothing and correct nexus device frame dimensions for screenshots (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

DevTools: disable smoothing and correct nexus device frame dimensions for screenshots For Nexus5X and Nexus6P presets, the existing SVGs were not well sized. That is: height of device outline !== insets.top + screenSize.height + insets.bottom This produced a noticeable gap in device mode screenshots. This CL corrects the SVGs and insets to match measured dimensions. Additionally, canvas drawn images look blurry in a device mode screenshots since canvas contexts' imageSmoothingEnabled property is true by default. This CL disables unnecessary smoothing. BUG=652938 Review-Url: https://codereview.chromium.org/2387353005 Cr-Commit-Position: refs/heads/master@{#424001} (cherry picked from commit ecbadddd6fdc69baeca94183e6805ba10eb587e2) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
luoe
This CL was created from git drover. It merges an approved change into Beta 54, ...
4 years, 2 months ago (2016-10-10 02:22:48 UTC) #2
kozy
lgtm
4 years, 2 months ago (2016-10-10 17:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408603002/1
4 years, 2 months ago (2016-10-10 17:34:52 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:39:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698