Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/156859)
4 years, 2 months ago
(2016-10-08 00:45:14 UTC)
#7
4 years, 2 months ago
(2016-10-10 20:28:05 UTC)
#12
Dry run: This issue passed the CQ dry run.
Ted C
On 2016/10/10 20:26:01, nasko (slow) wrote: > Hey Ted, > Can you take another look? ...
4 years, 2 months ago
(2016-10-10 20:30:56 UTC)
#13
On 2016/10/10 20:26:01, nasko (slow) wrote:
> Hey Ted,
> Can you take another look? I missed few locations that needed updating.
> Thanks!
> Nasko
still lgtm
nasko
The CQ bit was checked by nasko@chromium.org
4 years, 2 months ago
(2016-10-10 20:32:25 UTC)
#14
4 years, 2 months ago
(2016-10-10 20:40:15 UTC)
#16
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== Pass extra parameter to the Java WebContentsDelegateAndroid. This CL is ...
4 years, 2 months ago
(2016-10-10 20:43:29 UTC)
#17
Message was sent while issue was closed.
Description was changed from
==========
Pass extra parameter to the Java WebContentsDelegateAndroid.
This CL is a follow up to https://codereview.chromium.org/2385363002/
which added a new parameter to WebContentsDelegate::WebContentsCreated.
It adds the extra parameter in the C++ to Java transition.
BUG=649855
==========
to
==========
Pass extra parameter to the Java WebContentsDelegateAndroid.
This CL is a follow up to https://codereview.chromium.org/2385363002/
which added a new parameter to WebContentsDelegate::WebContentsCreated.
It adds the extra parameter in the C++ to Java transition.
BUG=649855
Committed: https://crrev.com/04cfc1198b20fb1aea618c89ce9a8b579101a879
Cr-Commit-Position: refs/heads/master@{#424229}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/04cfc1198b20fb1aea618c89ce9a8b579101a879 Cr-Commit-Position: refs/heads/master@{#424229}
4 years, 2 months ago
(2016-10-10 20:43:30 UTC)
#18
Issue 2408523002: Pass extra parameter to the Java WebContentsDelegateAndroid.
(Closed)
Created 4 years, 2 months ago by nasko
Modified 4 years, 2 months ago
Reviewers: Ted C
Base URL:
Comments: 0