Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2408523002: Pass extra parameter to the Java WebContentsDelegateAndroid. (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass extra parameter to the Java WebContentsDelegateAndroid. This CL is a follow up to https://codereview.chromium.org/2385363002/ which added a new parameter to WebContentsDelegate::WebContentsCreated. It adds the extra parameter in the C++ to Java transition. BUG=649855 Committed: https://crrev.com/04cfc1198b20fb1aea618c89ce9a8b579101a879 Cr-Commit-Position: refs/heads/master@{#424229}

Patch Set 1 #

Patch Set 2 : Add parameter to TabWebContentsDelegateAndroid and TabObserver. #

Messages

Total messages: 18 (9 generated)
nasko
Hey Ted, Can you review this trivial CL for me? Thanks in advance! Nasko
4 years, 2 months ago (2016-10-07 23:38:20 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-10-07 23:42:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408523002/1
4 years, 2 months ago (2016-10-08 00:23:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/156859)
4 years, 2 months ago (2016-10-08 00:45:14 UTC) #7
nasko
Hey Ted, Can you take another look? I missed few locations that needed updating. Thanks! ...
4 years, 2 months ago (2016-10-10 20:26:01 UTC) #10
Ted C
On 2016/10/10 20:26:01, nasko (slow) wrote: > Hey Ted, > Can you take another look? ...
4 years, 2 months ago (2016-10-10 20:30:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408523002/20001
4 years, 2 months ago (2016-10-10 20:32:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 20:40:15 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 20:43:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04cfc1198b20fb1aea618c89ce9a8b579101a879
Cr-Commit-Position: refs/heads/master@{#424229}

Powered by Google App Engine
This is Rietveld 408576698