Move memory observer off OutputSurface/CompositorFrameSink

Move memory observer off OutputSurface/CompositorFrameSink

Instead make ContextProviderCommandBuffer be a memory observer, and
avoid interfaces inheriting other interfaces.

R=ericrk@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2871a8c3516e495b9e9acedfe9c0fd43dc9b7b06
Cr-Commit-Position: refs/heads/master@{#424039}

[danakj, 2016-10-07 23:21:53]

Description was changed from

==========
Move memory observer off OutputSurface/CompositorFrameSink

Instead make ContextProviderCommandBuffer be a memory observer, and
avoid interfaces inheriting other interfaces.

R=ericrk@chromium.org
BUG=606056
==========

to

==========
Move memory observer off OutputSurface/CompositorFrameSink

Instead make ContextProviderCommandBuffer be a memory observer, and
avoid interfaces inheriting other interfaces.

R=ericrk@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-07 23:22:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-10-07 23:22:30]

danakj@chromium.org changed reviewers:
+ jbauman@chromium.org

[danakj, 2016-10-07 23:22:30]

+jbauman for content/ parts

[commit-bot: I haz the power, 2016-10-07 23:22:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-07 23:48:50]

PTAL detaching from thread and got rid of bind_succeeded_ early out

[danakj, 2016-10-07 23:48:59]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 23:49:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ericrk, 2016-10-07 23:50:15]

lgtm

https://codereview.chromium.org/2408513002/diff/1/cc/output/output_surface.cc
File cc/output/output_surface.cc (left):

https://codereview.chromium.org/2408513002/diff/1/cc/output/output_surface.cc...
cc/output/output_surface.cc:41: class SkiaGpuTraceMemoryDump : public
SkTraceMemoryDump {
so glad this is no longer duplicated :D

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/context_provider_command_buffer.cc:63: explicit
SkiaGpuTraceMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
nit: pre-existing, but can you drop the "explicit"

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/context_provider_command_buffer.cc:449: if
(!bind_succeeded_)
per our discussion, this isn't needed (you only register if this succeeded).

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/context_provider_command_buffer.cc:454:
base::Optional<base::AutoLock> hold;
you may want to detach from thread here and at the end.

[danakj, 2016-10-08 00:02:40]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-10-08 00:02:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-08 00:03:03]

m

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/context_provider_command_buffer.cc:449: if
(!bind_succeeded_)
On 2016/10/07 23:50:14, ericrk wrote:
> per our discussion, this isn't needed (you only register if this succeeded).

Done.

https://codereview.chromium.org/2408513002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/context_provider_command_buffer.cc:454:
base::Optional<base::AutoLock> hold;
On 2016/10/07 23:50:14, ericrk wrote:
> you may want to detach from thread here and at the end.

Done.

[danakj, 2016-10-08 00:03:10]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-10-08 00:03:21]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 00:03:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-10-08 00:10:20]

content/common/gpu lgtm

[danakj, 2016-10-08 01:21:26]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-10-08 01:21:30]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 01:54:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-08 01:56:03]

Description was changed from

==========
Move memory observer off OutputSurface/CompositorFrameSink

Instead make ContextProviderCommandBuffer be a memory observer, and
avoid interfaces inheriting other interfaces.

R=ericrk@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Move memory observer off OutputSurface/CompositorFrameSink

Instead make ContextProviderCommandBuffer be a memory observer, and
avoid interfaces inheriting other interfaces.

R=ericrk@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2871a8c3516e495b9e9acedfe9c0fd43dc9b7b06
Cr-Commit-Position: refs/heads/master@{#424039}
==========

[commit-bot: I haz the power, 2016-10-08 01:56:04]

Patchset 2 (id:??) landed as
https://crrev.com/2871a8c3516e495b9e9acedfe9c0fd43dc9b7b06
Cr-Commit-Position: refs/heads/master@{#424039}