Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html

Issue 2408493002: Import wpt@357b83b809e3cbc7a1805e7c3ca108a7980d782f (Closed)
Patch Set: Added one more win7-specific baseline Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/custom-elements/adopted-callback-expected.txt ('k') | third_party/WebKit/LayoutTests/imported/wpt/custom-elements/connected-callbacks.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html
diff --git a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html
index 9bcc9befb1a96ef1c65de51a5c426457b3ff5570..bd467912b999596f1a8523928d7db2cdd09f64c7 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html
+++ b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html
@@ -7,165 +7,157 @@
<link rel="help" href="https://w3c.github.io/webcomponents/spec/custom/#dfn-attribute-changed-callback">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
+<script src="resources/custom-elements-helpers.js"></script>
</head>
<body>
<div id="log"></div>
<script>
-var argumentList = [];
-class MyCustomElement extends HTMLElement {
- attributeChangedCallback(name, oldValue, newValue, namespace) {
- argumentList.push({arguments: arguments, value: this.getAttributeNS(namespace, name)});
- }
-}
-MyCustomElement.observedAttributes = ['title', 'id', 'r'];
-customElements.define('my-custom-element', MyCustomElement);
+var customElement = define_new_custom_element(['title', 'id', 'r']);
test(function () {
- var instance = document.createElement('my-custom-element');
- argumentList = [];
+ const instance = document.createElement(customElement.name);
+ assert_array_equals(customElement.takeLog().types(), ['constructed']);
instance.setAttribute('title', 'foo');
assert_equals(instance.getAttribute('title'), 'foo');
- assert_equals(argumentList.length, 1);
- assert_equals(argumentList[0].value, 'foo');
- assert_array_equals(argumentList[0].arguments, ['title', null, 'foo', null]);
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: null, newValue: 'foo', namespace: null});
instance.removeAttribute('title');
assert_equals(instance.getAttribute('title'), null);
- assert_equals(argumentList.length, 2);
- assert_equals(argumentList[1].value, null);
- assert_array_equals(argumentList[1].arguments, ['title', 'foo', null, null]);
-
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'foo', newValue: null, namespace: null});
}, 'setAttribute and removeAttribute must enqueue and invoke attributeChangedCallback');
test(function () {
- var instance = document.createElement('my-custom-element');
- argumentList = [];
+ var instance = document.createElement(customElement.name);
+ assert_array_equals(customElement.takeLog().types(), ['constructed']);
instance.setAttributeNS('http://www.w3.org/2000/svg', 'title', 'hello');
assert_equals(instance.getAttribute('title'), 'hello');
- assert_equals(argumentList.length, 1);
- assert_equals(argumentList[0].value, 'hello');
- assert_array_equals(argumentList[0].arguments, ['title', null, 'hello', 'http://www.w3.org/2000/svg']);
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: null, newValue: 'hello', namespace: 'http://www.w3.org/2000/svg'});
instance.removeAttributeNS('http://www.w3.org/2000/svg', 'title');
assert_equals(instance.getAttribute('title'), null);
- assert_equals(argumentList.length, 2);
- assert_equals(argumentList[1].value, null);
- assert_array_equals(argumentList[1].arguments, ['title', 'hello', null, 'http://www.w3.org/2000/svg']);
-
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'hello', newValue: null, namespace: 'http://www.w3.org/2000/svg'});
}, 'setAttributeNS and removeAttributeNS must enqueue and invoke attributeChangedCallback');
test(function () {
- var instance = document.createElement('my-custom-element');
- argumentList = [];
+ var instance = document.createElement(customElement.name);
+ assert_array_equals(customElement.takeLog().types(), ['constructed']);
var attr = document.createAttribute('id');
attr.value = 'bar';
instance.setAttributeNode(attr);
assert_equals(instance.getAttribute('id'), 'bar');
- assert_equals(argumentList.length, 1);
- assert_equals(argumentList[0].value, 'bar');
- assert_array_equals(argumentList[0].arguments, ['id', null, 'bar', null]);
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'id', oldValue: null, newValue: 'bar', namespace: null});
instance.removeAttributeNode(attr);
assert_equals(instance.getAttribute('id'), null);
- assert_equals(argumentList.length, 2);
- assert_equals(argumentList[1].value, null);
- assert_array_equals(argumentList[1].arguments, ['id', 'bar', null, null]);
-
-}, 'setAttributeNode and removeAttributeNS must enqueue and invoke attributeChangedCallback');
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'id', oldValue: 'bar', newValue: null, namespace: null});
+}, 'setAttributeNode and removeAttributeNode must enqueue and invoke attributeChangedCallback for an HTML attribute');
test(function () {
- var instance = document.createElement('my-custom-element');
- argumentList = [];
+ const instance = document.createElement(customElement.name);
+ assert_array_equals(customElement.takeLog().types(), ['constructed']);
- var attr = document.createAttributeNS('http://www.w3.org/2000/svg', 'r');
+ const attr = document.createAttributeNS('http://www.w3.org/2000/svg', 'r');
attr.value = '100';
instance.setAttributeNode(attr);
assert_equals(instance.getAttribute('r'), '100');
- assert_equals(argumentList.length, 1);
- assert_equals(argumentList[0].value, '100');
- assert_array_equals(argumentList[0].arguments, ['r', null, '100', 'http://www.w3.org/2000/svg']);
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'r', oldValue: null, newValue: '100', namespace: 'http://www.w3.org/2000/svg'});
instance.removeAttributeNode(attr);
assert_equals(instance.getAttribute('r'), null);
- assert_equals(argumentList.length, 2);
- assert_equals(argumentList[1].value, null);
- assert_array_equals(argumentList[1].arguments, ['r', '100', null, 'http://www.w3.org/2000/svg']);
-}, 'setAttributeNode and removeAttributeNS must enqueue and invoke attributeChangedCallback');
+ var logEntries = customElement.takeLog();
+ assert_array_equals(logEntries.types(), ['attributeChanged']);
+ assert_attribute_log_entry(logEntries.last(), {name: 'r', oldValue: '100', newValue: null, namespace: 'http://www.w3.org/2000/svg'});
+}, 'setAttributeNode and removeAttributeNS must enqueue and invoke attributeChangedCallback for an SVG attribute');
test(function () {
- var callsToOld = [];
- var callsToNew = [];
+ const callsToOld = [];
+ const callsToNew = [];
class CustomElement extends HTMLElement { }
- CustomElement.prototype.attributeChangedCallback = function () {
- callsToOld.push(Array.from(arguments));
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ callsToOld.push(create_attribute_changed_callback_log(this, ...args));
}
CustomElement.observedAttributes = ['title'];
customElements.define('element-with-mutated-attribute-changed-callback', CustomElement);
- CustomElement.prototype.attributeChangedCallback = function () {
- callsToNew.push(Array.from(arguments));
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ callsToNew.push(create_attribute_changed_callback_log(this, ...args));
}
- var instance = document.createElement('element-with-mutated-attribute-changed-callback');
+ const instance = document.createElement('element-with-mutated-attribute-changed-callback');
instance.setAttribute('title', 'hi');
assert_equals(instance.getAttribute('title'), 'hi');
assert_array_equals(callsToNew, []);
assert_equals(callsToOld.length, 1);
- assert_array_equals(callsToOld[0], ['title', null, 'hi', null]);
+ assert_attribute_log_entry(callsToOld[0], {name: 'title', oldValue: null, newValue: 'hi', namespace: null});
}, 'Mutating attributeChangedCallback after calling customElements.define must not affect the callback being invoked');
test(function () {
- var calls = [];
+ const calls = [];
class CustomElement extends HTMLElement {
- attributeChangedCallback() {
- calls.push(Array.from(arguments));
+ attributeChangedCallback(...args) {
+ calls.push(create_attribute_changed_callback_log(this, ...args));
}
}
CustomElement.observedAttributes = ['title'];
customElements.define('element-not-observing-id-attribute', CustomElement);
- var instance = document.createElement('element-not-observing-id-attribute');
+ const instance = document.createElement('element-not-observing-id-attribute');
+ assert_equals(calls.length, 0);
instance.setAttribute('title', 'hi');
assert_equals(calls.length, 1);
- assert_array_equals(calls[0], ['title', null, 'hi', null]);
+ assert_attribute_log_entry(calls[0], {name: 'title', oldValue: null, newValue: 'hi', namespace: null});
instance.setAttribute('id', 'some');
assert_equals(calls.length, 1);
-}, 'attributedChangedCallback must not be invoked when the observed attributes does not contain the attribute.');
+ assert_attribute_log_entry(calls[0], {name: 'title', oldValue: null, newValue: 'hi', namespace: null});
+}, 'attributedChangedCallback must not be invoked when the observed attributes does not contain the attribute');
test(function () {
- var calls = [];
+ const calls = [];
class CustomElement extends HTMLElement { }
- CustomElement.prototype.attributeChangedCallback = function () {
- calls.push(Array.from(arguments));
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ calls.push(create_attribute_changed_callback_log(this, ...args));
}
CustomElement.observedAttributes = ['title', 'lang'];
customElements.define('element-with-mutated-observed-attributes', CustomElement);
CustomElement.observedAttributes = ['title', 'id'];
- var instance = document.createElement('element-with-mutated-observed-attributes');
+ const instance = document.createElement('element-with-mutated-observed-attributes');
instance.setAttribute('title', 'hi');
assert_equals(calls.length, 1);
- assert_array_equals(calls[0], ['title', null, 'hi', null]);
+ assert_attribute_log_entry(calls[0], {name: 'title', oldValue: null, newValue: 'hi', namespace: null});
instance.setAttribute('id', 'some');
assert_equals(calls.length, 1);
instance.setAttribute('lang', 'en');
assert_equals(calls.length, 2);
- assert_array_equals(calls[0], ['title', null, 'hi', null]);
- assert_array_equals(calls[1], ['lang', null, 'en', null]);
+ assert_attribute_log_entry(calls[1], {name: 'lang', oldValue: null, newValue: 'en', namespace: null});
}, 'Mutating observedAttributes after calling customElements.define must not affect the set of attributes for which attributedChangedCallback is invoked');
test(function () {
var calls = [];
class CustomElement extends HTMLElement { }
- CustomElement.prototype.attributeChangedCallback = function () {
- calls.push(Array.from(arguments));
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ calls.push(create_attribute_changed_callback_log(this, ...args));
}
CustomElement.observedAttributes = { [Symbol.iterator]: function *() { yield 'lang'; yield 'style'; } };
customElements.define('element-with-generator-observed-attributes', CustomElement);
@@ -173,20 +165,59 @@ test(function () {
var instance = document.createElement('element-with-generator-observed-attributes');
instance.setAttribute('lang', 'en');
assert_equals(calls.length, 1);
- assert_array_equals(calls[0], ['lang', null, 'en', null]);
+ assert_attribute_log_entry(calls[0], {name: 'lang', oldValue: null, newValue: 'en', namespace: null});
instance.setAttribute('lang', 'ja');
assert_equals(calls.length, 2);
- assert_array_equals(calls[1], ['lang', 'en', 'ja', null]);
+ assert_attribute_log_entry(calls[1], {name: 'lang', oldValue: 'en', newValue: 'ja', namespace: null});
instance.setAttribute('title', 'hello');
assert_equals(calls.length, 2);
instance.setAttribute('style', 'font-size: 2rem');
assert_equals(calls.length, 3);
- assert_array_equals(calls[2], ['style', null, 'font-size: 2rem', null]);
+ assert_attribute_log_entry(calls[2], {name: 'style', oldValue: null, newValue: 'font-size: 2rem', namespace: null});
}, 'attributedChangedCallback must be enqueued for attributes specified in a non-Array iterable observedAttributes');
+test(function () {
+ var calls = [];
+ class CustomElement extends HTMLElement { }
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ calls.push(create_attribute_changed_callback_log(this, ...args));
+ }
+ CustomElement.observedAttributes = ['style'];
+ customElements.define('element-with-style-attribute-observation', CustomElement);
+
+ var instance = document.createElement('element-with-style-attribute-observation');
+ assert_equals(calls.length, 0);
+
+ instance.style.fontSize = '10px';
+ assert_equals(calls.length, 1);
+ assert_attribute_log_entry(calls[0], {name: 'style', oldValue: null, newValue: 'font-size: 10px;', namespace: null});
+
+ instance.style.fontSize = '20px';
+ assert_equals(calls.length, 2);
+ assert_attribute_log_entry(calls[1], {name: 'style', oldValue: 'font-size: 10px;', newValue: 'font-size: 20px;', namespace: null});
+
+}, 'attributedChangedCallback must be enqueued for style attribute change by mutating inline style declaration');
+
+test(function () {
+ var calls = [];
+ class CustomElement extends HTMLElement { }
+ CustomElement.prototype.attributeChangedCallback = function (...args) {
+ calls.push(create_attribute_changed_callback_log(this, ...args));
+ }
+ CustomElement.observedAttributes = ['title'];
+ customElements.define('element-with-no-style-attribute-observation', CustomElement);
+
+ var instance = document.createElement('element-with-no-style-attribute-observation');
+ assert_equals(calls.length, 0);
+ instance.style.fontSize = '10px';
+ assert_equals(calls.length, 0);
+ instance.title = 'hello';
+ assert_attribute_log_entry(calls[0], {name: 'title', oldValue: null, newValue: 'hello', namespace: null});
+}, 'attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed');
+
</script>
</body>
</html>
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/custom-elements/adopted-callback-expected.txt ('k') | third_party/WebKit/LayoutTests/imported/wpt/custom-elements/connected-callbacks.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698