Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2408423004: DBC: Fix CheckCids instruction (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/constants_dbc.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-10-12 19:26:33 UTC) #2
Florian Schneider
Lgtm!
4 years, 2 months ago (2016-10-12 19:44:51 UTC) #3
zra
4 years, 2 months ago (2016-10-12 19:45:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08d70cdca5cb90a203119ff9ffb1bcc7f4cf4895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698