Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2408403002: Change TF regression test to not trigger tons of allocation (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change TF regression test to not trigger tons of allocation Instead of allocating an ArrayBuffer in the test, use a different example from the original bug. R=bmeurer@chromium.org BUG=chromium:644631, v8:5504 Committed: https://crrev.com/1eaf2927bac050b466f490082e55a2dbf6a2648d Cr-Commit-Position: refs/heads/master@{#40195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M test/mjsunit/regress/regress-crbug-644631.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
adamk
4 years, 2 months ago (2016-10-12 00:03:40 UTC) #1
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-12 03:00:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408403002/1
4 years, 2 months ago (2016-10-12 03:00:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/10495) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-12 03:44:27 UTC) #6
Michael Achenbach
Thanks!
4 years, 2 months ago (2016-10-12 06:55:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408403002/1
4 years, 2 months ago (2016-10-12 06:55:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 07:33:11 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:33:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eaf2927bac050b466f490082e55a2dbf6a2648d
Cr-Commit-Position: refs/heads/master@{#40195}

Powered by Google App Engine
This is Rietveld 408576698