Clean-up: Replaces Font with FontList in ui/message_center.

ui/message_center/views/bounded_label.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_MESSAGE_CENTER_BOUNDED_LABEL_H_
 #define UI_MESSAGE_CENTER_BOUNDED_LABEL_H_
 
 #include <list>
 #include <map>
 
 #include "base/memory/scoped_ptr.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/message_center/message_center_export.h"
 #include "ui/views/view.h"
 
 namespace gfx {
-class Font;
-}
+class FontList;
+}  // namespace gfx

[Jun Mukai, 2013/09/10 08:59:41]

you can omit "// namespace ~" comment in this size of section in the header.

[Yuki, 2013/09/10 09:16:34]

I know some of people omit it, but I was not able to find if it's okay or not in
the style guide, or in what cases we should omit it if it's okay.

As I read the style guide, it's at least okay to always put an ending comment. 
Considering there is no description how to omit it, probably it's recommended to
always write it.

[Jun Mukai, 2013/09/10 17:29:46]

If the coding style doesn't say specifically, usually follow the convention on
that module. As I quickly checked, ui/message_center tends to omit this thing,
see message_center.h or notification_list.h or views/message_popup_collection.h
(except for views/message_center_view.h)

It's still up to you though, you can go ahead with this, but I'd prefer to omit.

[Yuki, 2013/09/11 12:53:18]

Done.

 
 namespace message_center {
 
 class InnerBoundedLabel;
 
 namespace test {
 class BoundedLabelTest;
-}
+}  // namespace test

[Jun Mukai, 2013/09/10 08:59:41]

ditto

[Yuki, 2013/09/10 09:16:34]

Done.

 
 // BoundedLabels display left aligned text up to a maximum number of lines, with
 // ellipsis at the end of the last line for any omitted text. BoundedLabel is a
 // direct subclass of views::Views rather than a subclass of views::Label
 // to avoid exposing some of views::Label's methods that can't be made to work
 // with BoundedLabel. See the description of InnerBoundedLabel in the
 // bounded_label.cc file for details.
 class MESSAGE_CENTER_EXPORT BoundedLabel : public views::View {
  public:
-  BoundedLabel(const string16& text, gfx::Font font);
+  BoundedLabel(const string16& text, const gfx::FontList& font_list);
   BoundedLabel(const string16& text);
   virtual ~BoundedLabel();
 
   void SetColors(SkColor textColor, SkColor backgroundColor);
   void SetLineHeight(int height);  // Pass in 0 for default height.
   void SetLineLimit(int lines);  // Pass in -1 for no limit.
 
   int GetLineHeight() const;
   int GetLineLimit() const;
 
@@ skipping 21 matching lines @@
 
   scoped_ptr<InnerBoundedLabel> label_;
   int line_limit_;
 
   DISALLOW_COPY_AND_ASSIGN(BoundedLabel);
 };
 
 }  // namespace message_center
 
 #endif  // UI_MESSAGE_CENTER_BOUNDED_LABEL_H_