Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2408393003: Manage insecure content flags in SSLManager, not WebContentsImpl (Closed)
Patch Set: fix test failure Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index d1fc9a1bc034c62de03ce089918abc06c9aa7d6b..68278ee11eeb574c1ead18f36b2f065fc21daf93 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -432,20 +432,6 @@ class CONTENT_EXPORT WebContentsImpl
bool GetAllowOtherViews() override;
#endif
- // Returns true if this is a secure page which has displayed content
- // loaded over insecure HTTP.
- bool DisplayedInsecureContent() const;
-
- // Returns true if this page has displayed content loaded over HTTPS
- // with certificate errors.
- bool DisplayedContentWithCertErrors() const;
-
- // Returns true if this page is HTTP and has displayed a password field.
- bool DisplayedPasswordFieldOnHttp() const;
-
- // Returns true if this page is HTTP and has displayed a credit card field.
- bool DisplayedCreditCardFieldOnHttp() const;
-
// Implementation of PageNavigator.
WebContents* OpenURL(const OpenURLParams& params) override;
@@ -1249,20 +1235,6 @@ class CONTENT_EXPORT WebContentsImpl
// The canonicalized character encoding.
std::string canonical_encoding_;
- // True if this is a secure page which displayed mixed content (loaded
- // over HTTP).
- bool displayed_insecure_content_;
-
- // True if this page displayed subresources loaded with HTTPS
- // certificate errors.
- bool displayed_content_with_cert_errors_;
-
- // True if this page displayed a password input field on HTTP.
- bool displayed_password_field_on_http_;
-
- // True if this page displayed a credit card input field on HTTP.
- bool displayed_credit_card_field_on_http_;
-
// Whether the initial empty page has been accessed by another page, making it
// unsafe to show the pending URL. Usually false unless another window tries
// to modify the blank page. Always false after the first commit.

Powered by Google App Engine
This is Rietveld 408576698