Move persistent gesture state to Document, add DocumentUserGestureToken

third_party/WebKit/Source/core/input/PointerEventManager.cpp

Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 5dae54204c09d59fadb4dc303b6dfb2500124de1..d6c05afa253a4cbce310004aa02147c1d66bc075 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -4,6 +4,7 @@
 
 #include "core/input/PointerEventManager.h"
 
+#include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/events/MouseEvent.h"
@@ -171,8 +172,8 @@ WebInputEventResult PointerEventManager::dispatchPointerEvent(
     std::unique_ptr<UserGestureIndicator> gestureIndicator;
     if (eventType == EventTypeNames::pointerup &&
         pointerEvent->pointerType() == "touch") {
-      gestureIndicator =
-          wrapUnique(new UserGestureIndicator(UserGestureToken::create()));
+      gestureIndicator = wrapUnique(new UserGestureIndicator(
+          DocumentUserGestureToken::create(m_frame->document())));

[Rick Byers, 2016/10/17 17:02:46]

I'm not positive what m_frame refers to here in all cases. Navid would it be
better to use target's document instead of m_frame to ensure we're getting the
inner-most document?

[Navid Zolghadr, 2016/10/17 17:18:05]

Unfortunately that is the case for touch events. m_frame is the frame that this
PointerEventManager belongs to. Every iframe has its own EventHandler and
PointerEventManager. However all the touch events and touch pointer events are
being sent directly to the target node inside the innermost iframe right from
the top level frame and PointerEventManager. So if the pointerType is touch
m_frame refers to the main page frame. So if we would like to create the gesture
for the inner most iframe it is better to use iframe that the target is in. I
guess we need to cast to to Node and get the document.

[Nate Chapin, 2016/10/18 23:26:33]

Done. It's safe to assume that the EventTarget is a Node here, right?

[Rick Byers, 2016/10/24 18:30:46]

I don't think so - I believe there are rare scenarios where a pointer event can
be dispatched to a document or the window.  It's probably OK not to set the
document gesture state in those cases if you want to keep the code trivial.

[Nate Chapin, 2016/10/24 18:45:18]

SG, added a null check.

     }
 
     DispatchEventResult dispatchResult = target->dispatchEvent(pointerEvent);