third_party/WebKit/Source/core/page/DragController.cpp - Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)

Patch Set: Add TODO, null check toNode() result in PointerEventManager Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 5f2b5a7af08209d10865e5562a07c4b49745ad10..36f46d356c2d51687be1819b9512ea0b436b2309 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -34,6 +34,7 @@

#include "core/clipboard/DataTransferAccessPolicy.h"

#include "core/dom/Document.h"

#include "core/dom/DocumentFragment.h"

+#include "core/dom/DocumentUserGestureToken.h"

#include "core/dom/Element.h"

#include "core/dom/Node.h"

#include "core/dom/Text.h"

@@ -241,6 +242,8 @@ bool DragController::performDrag(DragData* dragData) {

DCHECK(dragData);

m_documentUnderMouse = m_page->deprecatedLocalMainFrame()->documentAtPoint(

dragData->clientPosition());

+ UserGestureIndicator gesture(DocumentUserGestureToken::create(

+ m_documentUnderMouse, UserGestureToken::NewGesture));

if ((m_dragDestinationAction & DragDestinationActionDHTML) &&

m_documentIsHandlingDrag) {

LocalFrame* mainFrame = m_page->deprecatedLocalMainFrame();