Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 515c9b2a1e4d61e72e8d90727a2a550008b922e5..27f6a4f9e8ff8bffc14da100d1ff62595cd327d8 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -39,6 +39,7 @@
#include "core/css/resolver/StyleResolver.h"
#include "core/css/resolver/ViewportStyleResolver.h"
#include "core/dom/Document.h"
+#include "core/dom/DocumentUserGestureToken.h"
#include "core/dom/Fullscreen.h"
#include "core/dom/NodeComputedStyle.h"
#include "core/dom/Range.h"
@@ -6686,7 +6687,7 @@ TEST_P(ParameterizedWebFrameTest, ModifiedClickNewWindow) {
PlatformMouseEvent::RealOrIndistinguishable, String(), nullptr);
FrameLoadRequest frameRequest(document, ResourceRequest(destination));
frameRequest.setTriggeringEvent(event);
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
toLocalFrame(webViewHelper.webView()->page()->mainFrame())
->loader()
.load(frameRequest);
@@ -7408,7 +7409,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenLayerSize) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7443,7 +7444,7 @@ TEST_F(WebFrameTest, FullscreenLayerNonScrollable) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7487,7 +7488,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenMainFrame) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7528,7 +7529,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenSubframe) {
toWebLocalFrameImpl(webViewHelper.webView()->mainFrame()->firstChild())
->frame()
->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7572,7 +7573,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenWithTinyViewport) {
EXPECT_FLOAT_EQ(5.0, webViewImpl->maximumPageScaleFactor());
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7609,7 +7610,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenResizeWithTinyViewport) {
LayoutViewItem layoutViewItem =
webViewHelper.webView()->mainFrameImpl()->frameView()->layoutViewItem();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7671,7 +7672,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenRestoreScaleFactorUponExiting) {
{
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(UserGestureToken::create());
+ UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
Fullscreen::requestFullscreen(*document->body(),
Fullscreen::PrefixedRequest);
}
@@ -7733,7 +7734,7 @@ TEST_P(ParameterizedWebFrameTest, ClearFullscreenConstraintsOnNavigation) {
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
UserGestureIndicator gesture(
- UserGestureToken::create(UserGestureToken::NewGesture));
+ DocumentUserGestureToken::create(document, UserGestureToken::NewGesture));
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();

Powered by Google App Engine
This is Rietveld 408576698