Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)
Patch Set: Re-add dropped null check Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 #include "core/page/scrolling/ScrollCustomizationCallbacks.h" 131 #include "core/page/scrolling/ScrollCustomizationCallbacks.h"
132 #include "core/page/scrolling/ScrollState.h" 132 #include "core/page/scrolling/ScrollState.h"
133 #include "core/page/scrolling/ScrollStateCallback.h" 133 #include "core/page/scrolling/ScrollStateCallback.h"
134 #include "core/page/scrolling/TopDocumentRootScrollerController.h" 134 #include "core/page/scrolling/TopDocumentRootScrollerController.h"
135 #include "core/paint/PaintLayer.h" 135 #include "core/paint/PaintLayer.h"
136 #include "core/svg/SVGAElement.h" 136 #include "core/svg/SVGAElement.h"
137 #include "core/svg/SVGDocumentExtensions.h" 137 #include "core/svg/SVGDocumentExtensions.h"
138 #include "core/svg/SVGElement.h" 138 #include "core/svg/SVGElement.h"
139 #include "platform/EventDispatchForbiddenScope.h" 139 #include "platform/EventDispatchForbiddenScope.h"
140 #include "platform/RuntimeEnabledFeatures.h" 140 #include "platform/RuntimeEnabledFeatures.h"
141 #include "platform/UserGestureIndicator.h"
142 #include "platform/graphics/CompositorMutableProperties.h" 141 #include "platform/graphics/CompositorMutableProperties.h"
143 #include "platform/graphics/CompositorMutation.h" 142 #include "platform/graphics/CompositorMutation.h"
144 #include "platform/scroll/ScrollableArea.h" 143 #include "platform/scroll/ScrollableArea.h"
145 #include "wtf/BitVector.h" 144 #include "wtf/BitVector.h"
146 #include "wtf/HashFunctions.h" 145 #include "wtf/HashFunctions.h"
147 #include "wtf/text/CString.h" 146 #include "wtf/text/CString.h"
148 #include "wtf/text/StringBuilder.h" 147 #include "wtf/text/StringBuilder.h"
149 #include "wtf/text/TextPosition.h" 148 #include "wtf/text/TextPosition.h"
150 #include <memory> 149 #include <memory>
151 150
(...skipping 2448 matching lines...) Expand 10 before | Expand all | Expand 10 after
2600 WebFocusTypeForward, nullptr)); 2599 WebFocusTypeForward, nullptr));
2601 return; 2600 return;
2602 } 2601 }
2603 } 2602 }
2604 2603
2605 if (!document().page()->focusController().setFocusedElement( 2604 if (!document().page()->focusController().setFocusedElement(
2606 this, document().frame(), params)) 2605 this, document().frame(), params))
2607 return; 2606 return;
2608 2607
2609 if (document().focusedElement() == this && 2608 if (document().focusedElement() == this &&
2610 UserGestureIndicator::processedUserGestureSinceLoad()) { 2609 document().hasReceivedUserGesture()) {
2611 // Bring up the keyboard in the context of anything triggered by a user 2610 // Bring up the keyboard in the context of anything triggered by a user
2612 // gesture. Since tracking that across arbitrary boundaries (eg. 2611 // gesture. Since tracking that across arbitrary boundaries (eg.
2613 // animations) is difficult, for now we match IE's heuristic and bring 2612 // animations) is difficult, for now we match IE's heuristic and bring
2614 // up the keyboard if there's been any gesture since load. 2613 // up the keyboard if there's been any gesture since load.
2615 document().page()->chromeClient().showImeIfNeeded(); 2614 document().page()->chromeClient().showImeIfNeeded();
2616 } 2615 }
2617 } 2616 }
2618 2617
2619 void Element::updateFocusAppearance( 2618 void Element::updateFocusAppearance(
2620 SelectionBehaviorOnFocus selectionBehavior) { 2619 SelectionBehaviorOnFocus selectionBehavior) {
(...skipping 1455 matching lines...) Expand 10 before | Expand all | Expand 10 after
4076 } 4075 }
4077 4076
4078 DEFINE_TRACE_WRAPPERS(Element) { 4077 DEFINE_TRACE_WRAPPERS(Element) {
4079 if (hasRareData()) { 4078 if (hasRareData()) {
4080 visitor->traceWrappers(elementRareData()); 4079 visitor->traceWrappers(elementRareData());
4081 } 4080 }
4082 ContainerNode::traceWrappers(visitor); 4081 ContainerNode::traceWrappers(visitor);
4083 } 4082 }
4084 4083
4085 } // namespace blink 4084 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698