Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2408303003: Don't count nested function scopes towards MaxNestedContextChainlength (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
CC:
jochen (gone - plz use gerrit), rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't count nested function scopes towards MaxNestedContextChainlength This is allocating registers in the function for all inner contexts that can be active in that function, so that nested blocks always have O(1) access to all outer contexts. However, currently it's always walking into nested functions, overallocating the number of registers, causing additional register pressure. BUG=v8:5484 Committed: https://crrev.com/35fc3d58a1f63edf979474aae7a91fc64f5867f6 Cr-Commit-Position: refs/heads/master@{#40214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-12 10:22:18 UTC) #2
jochen (gone - plz use gerrit)
that would explain why we couldn't get it to crash
4 years, 2 months ago (2016-10-12 10:41:09 UTC) #4
marja
lgtm, this is convincing, but I added bmeurer@ as a reviewer since he knows how ...
4 years, 2 months ago (2016-10-12 11:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408303003/1
4 years, 2 months ago (2016-10-12 11:52:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 12:14:32 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 12:15:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35fc3d58a1f63edf979474aae7a91fc64f5867f6
Cr-Commit-Position: refs/heads/master@{#40214}

Powered by Google App Engine
This is Rietveld 408576698