Add gpu and cc perf tests to new fyi tester

Add gpu and cc perf tests to new fyi tester

Also refactors generate_perf_json.py a bit.

BUG=639530
Committed: https://crrev.com/5e8b08e1e1d33dbf7b2fcb4447499c30eea863b6
Cr-Commit-Position: refs/heads/master@{#424637}

[martiniss, 2016-10-11 22:10:25]

Description was changed from

==========
Add gpu and cc perf tests to new fyi tester

BUG=
==========

to

==========
Add gpu and cc perf tests to new fyi tester

Also refactors generate_perf_json.py a bit.

BUG=639530
==========

[martiniss, 2016-10-11 22:10:25]

martiniss@chromium.org changed reviewers:
+ dtu@chromium.org, eyaich@chromium.org

[martiniss, 2016-10-11 22:10:33]

PTAL

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:412: BENCHMARK_NAME_WHITELIST = set([
I added this because otherwise it added all the benchmarks in the
//tools/benchmark directory, which I figured we wouldn't want to do?

[eyaich1, 2016-10-11 23:05:02]

lgtm

https://codereview.chromium.org/2408283002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.perf.fyi.json (left):

https://codereview.chromium.org/2408283002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.perf.fyi.json:185: "id": "build186-b4"
can you manually change the id on some of these to be build186-b4 that got
switched here?  The current device affinity generator doesn't work correctly
because we aren't using all the benchmarks and we want to split some of the
load.

I have to be honest that I was manually doing changes in these files for
testing, unaware that other people were using it...

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:412: BENCHMARK_NAME_WHITELIST = set([
On 2016/10/11 22:10:33, martiniss wrote:
> I added this because otherwise it added all the benchmarks in the
> //tools/benchmark directory, which I figured we wouldn't want to do?

Right.  Thanks for the addition.

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:422: u'dromaeo.cssqueryjquery.reference'
You can remove all the *.reference from this list.  We call
generate_telemetry_test twice for each benchmark name and that method adds the
.reference.  IT doesn't hurt because DiscoverClasses will never return something
with a .reference so it is a noop, but it is dead code.

[martiniss, 2016-10-11 23:32:02]

Done. Need dtu@ for OWNERS

https://codereview.chromium.org/2408283002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.perf.fyi.json (left):

https://codereview.chromium.org/2408283002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.perf.fyi.json:185: "id": "build186-b4"
On 2016/10/11 at 23:05:02, eyaich1 wrote:
> can you manually change the id on some of these to be build186-b4 that got
switched here?  The current device affinity generator doesn't work correctly
because we aren't using all the benchmarks and we want to split some of the
load.
done.
> 
> I have to be honest that I was manually doing changes in these files for
testing, unaware that other people were using it...

Ah ok. I'm starting to use it, because i'm moving some builders over to the
chromium recipe.

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2408283002/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:422: u'dromaeo.cssqueryjquery.reference'
On 2016/10/11 at 23:05:02, eyaich1 wrote:
> You can remove all the *.reference from this list.  We call
generate_telemetry_test twice for each benchmark name and that method adds the
.reference.  IT doesn't hurt because DiscoverClasses will never return something
with a .reference so it is a noop, but it is dead code.

Removed.

[dtu, 2016-10-12 00:29:14]

lgtm

[martiniss, 2016-10-12 00:35:21]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-10-12 00:35:21]

The patchset sent to the CQ was uploaded after l-g-t-m from eyaich@chromium.org
Link to the patchset: https://codereview.chromium.org/2408283002/#ps40001
(title: "Commetns.")

[commit-bot: I haz the power, 2016-10-12 00:35:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:35:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-12 01:37:43]

Description was changed from

==========
Add gpu and cc perf tests to new fyi tester

Also refactors generate_perf_json.py a bit.

BUG=639530
==========

to

==========
Add gpu and cc perf tests to new fyi tester

Also refactors generate_perf_json.py a bit.

BUG=639530

Committed: https://crrev.com/5e8b08e1e1d33dbf7b2fcb4447499c30eea863b6
Cr-Commit-Position: refs/heads/master@{#424637}
==========

[commit-bot: I haz the power, 2016-10-12 01:37:44]

Patchset 3 (id:??) landed as
https://crrev.com/5e8b08e1e1d33dbf7b2fcb4447499c30eea863b6
Cr-Commit-Position: refs/heads/master@{#424637}