Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js b/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js |
| index d62fb0ef5e73d12dd8af04e0f29c676a3a9a6621..40d2d63942c8a9f3c3e40ee5e00437aa046a3bd6 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js |
| @@ -45,6 +45,8 @@ WebInspector.ContentProviderBasedProject = function(workspace, id, type, display |
| workspace.addProject(this); |
| } |
| +WebInspector.ContentProviderBasedProject._metadata = Symbol("ContentProviderBasedProject.Metadata"); |
| + |
| WebInspector.ContentProviderBasedProject.prototype = { |
| /** |
| * @override |
| @@ -64,7 +66,7 @@ WebInspector.ContentProviderBasedProject.prototype = { |
| */ |
| requestMetadata: function(uiSourceCode) |
| { |
| - return Promise.resolve(/** @type {?WebInspector.UISourceCodeMetadata} */(null)); |
| + return Promise.resolve(uiSourceCode[WebInspector.ContentProviderBasedProject._metadata]); |
| }, |
| /** |
| @@ -275,10 +277,12 @@ WebInspector.ContentProviderBasedProject.prototype = { |
| /** |
| * @param {!WebInspector.UISourceCode} uiSourceCode |
| * @param {!WebInspector.ContentProvider} contentProvider |
| + * @param {?WebInspector.UISourceCodeMetadata} metadata |
| */ |
| - addUISourceCodeWithProvider: function(uiSourceCode, contentProvider) |
| + addUISourceCodeWithProvider: function(uiSourceCode, contentProvider, metadata) |
| { |
| this._contentProviders[uiSourceCode.url()] = contentProvider; |
| + uiSourceCode[WebInspector.ContentProviderBasedProject._metadata] = metadata || null; |
|
dgozman
2016/10/14 21:49:20
nit: no need for || null
lushnikov
2016/10/14 22:46:39
Done.
|
| this.addUISourceCode(uiSourceCode, true); |
| }, |
| @@ -290,7 +294,7 @@ WebInspector.ContentProviderBasedProject.prototype = { |
| addContentProvider: function(url, contentProvider) |
|
dgozman
2016/10/14 21:49:20
Why no metadata here?
lushnikov
2016/10/14 22:46:39
This method doesn't have any clients who're intere
|
| { |
| var uiSourceCode = this.createUISourceCode(url, contentProvider.contentType()); |
| - this.addUISourceCodeWithProvider(uiSourceCode, contentProvider); |
| + this.addUISourceCodeWithProvider(uiSourceCode, contentProvider, null); |
| return uiSourceCode; |
| }, |