DevTools: teach network UISourceCodes to return metadata

third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
  * @param {string} displayName
  */
 WebInspector.ContentProviderBasedProject = function(workspace, id, type, displayName)
 {
     WebInspector.ProjectStore.call(this, workspace, id, type, displayName);
     /** @type {!Object.<string, !WebInspector.ContentProvider>} */
     this._contentProviders = {};
     workspace.addProject(this);
 }
 
+WebInspector.ContentProviderBasedProject._metadata = Symbol("ContentProviderBasedProject.Metadata");
+
 WebInspector.ContentProviderBasedProject.prototype = {
     /**
      * @override
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @param {function(?string)} callback
      */
     requestFileContent: function(uiSourceCode, callback)
     {
         var contentProvider = this._contentProviders[uiSourceCode.url()];
         contentProvider.requestContent().then(callback);
     },
 
     /**
      * @override
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @return {!Promise<?WebInspector.UISourceCodeMetadata>}
      */
     requestMetadata: function(uiSourceCode)
     {
-        return Promise.resolve(/** @type {?WebInspector.UISourceCodeMetadata} */(null));
+        return Promise.resolve(uiSourceCode[WebInspector.ContentProviderBasedProject._metadata]);
     },
 
     /**
      * @override
      * @return {boolean}
      */
     canSetFileContent: function()
     {
         return false;
     },
@@ skipping 190 matching lines @@
      * @param {!WebInspector.Progress} progress
      */
     indexContent: function(progress)
     {
         setImmediate(progress.done.bind(progress));
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @param {!WebInspector.ContentProvider} contentProvider
+     * @param {?WebInspector.UISourceCodeMetadata} metadata
      */
-    addUISourceCodeWithProvider: function(uiSourceCode, contentProvider)
+    addUISourceCodeWithProvider: function(uiSourceCode, contentProvider, metadata)
     {
         this._contentProviders[uiSourceCode.url()] = contentProvider;
+        uiSourceCode[WebInspector.ContentProviderBasedProject._metadata] = metadata || null;

[dgozman, 2016/10/14 21:49:20]

nit: no need for || null

[lushnikov, 2016/10/14 22:46:39]

Done.

         this.addUISourceCode(uiSourceCode, true);
     },
 
     /**
      * @param {string} url
      * @param {!WebInspector.ContentProvider} contentProvider
      * @return {!WebInspector.UISourceCode}
      */
     addContentProvider: function(url, contentProvider)

[dgozman, 2016/10/14 21:49:20]

Why no metadata here?

[lushnikov, 2016/10/14 22:46:39]

This method doesn't have any clients who're interested in passing metadata.
As far as a need emerges, we'll plumb metadata here!

     {
         var uiSourceCode = this.createUISourceCode(url, contentProvider.contentType());
-        this.addUISourceCodeWithProvider(uiSourceCode, contentProvider);
+        this.addUISourceCodeWithProvider(uiSourceCode, contentProvider, null);
         return uiSourceCode;
     },
 
     /**
      * @param {string} path
      */
     removeFile: function(path)
     {
         delete this._contentProviders[path];
         this.removeUISourceCode(path);
     },
 
     reset: function()
     {
         this._contentProviders = {};
         this.removeProject();
         this.workspace().addProject(this);
     },
 
     dispose: function()
     {
         this._contentProviders = {};
         this.removeProject();
     },
 
     __proto__: WebInspector.ProjectStore.prototype
 }