Add tests where we split near an edge.

cc/quads/draw_polygon_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // We would like to use M_PI on windows too.
 #ifdef _WIN32
 #define _USE_MATH_DEFINES
 #endif
 
 #include <stddef.h>
 
 #include <limits>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
 #include "cc/output/bsp_compare_result.h"
 #include "cc/quads/draw_polygon.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/transform.h"
 
 namespace cc {
 
 #if !defined(OS_WIN)
 void DrawPolygon::RecomputeNormalForTesting() {
   ConstructNormal();
 }
+
+static int sign(float v) {
+  static const float epsilon = 0.00001f;
+
+  if (v > epsilon)
+    return 1;
+  if (v < -epsilon)
+    return -1;
+  return 0;
+}
+
+bool DrawPolygon::IsPlanarForTesting() const {
+  static const float epsilon = 0.00001f;
+  for (size_t i = 1; i < points_.size(); i++) {
+    if (gfx::DotProduct(points_[i] - points_[0], normal_) > epsilon)
+      return false;
+  }
+  return true;
+}
+
+bool DrawPolygon::IsConvexForTesting() const {
+  if (points_.size() < 3)
+    return true;
+
+  gfx::Vector3dF prev =
+      points_[points_.size() - 1] - points_[points_.size() - 2];
+  gfx::Vector3dF next = points_[0] - points_[points_.size() - 1];
+  int ccw = sign(gfx::DotProduct(CrossProduct(prev, next), normal_));
+  for (size_t i = 1; i < points_.size(); i++) {
+    prev = next;
+    next = points_[i] - points_[i - 1];
+    int next_sign = sign(gfx::DotProduct(CrossProduct(prev, next), normal_));
+    if (ccw == 0)
+      ccw = next_sign;
+    if (next_sign != 0 && next_sign != ccw)
+      return false;
+  }
+  return true;
+}
 #endif
 
 namespace {
 
 #define CREATE_NEW_DRAW_POLYGON(name, points_vector, normal, polygon_id) \
   DrawPolygon name(NULL, points_vector, normal, polygon_id)
 
 #define CREATE_NEW_DRAW_POLYGON_PTR(name, points_vector, normal, polygon_id) \
   std::unique_ptr<DrawPolygon> name(base::MakeUnique<DrawPolygon>(           \
       nullptr, points_vector, normal, polygon_id))
@@ skipping 273 matching lines @@
   vertices_b.push_back(gfx::Point3F(5.0f, 0.0f, 0.0f));
 
   CREATE_NEW_DRAW_POLYGON(polygon_a, vertices_a,
                           gfx::Vector3dF(0.0f, 0.0f, 1.0f), 0);
   CREATE_NEW_DRAW_POLYGON(polygon_b, vertices_b,
                           gfx::Vector3dF(-1.0f, 0.0f, 0.0f), 1);
 
   EXPECT_EQ(BSP_BACK, SideCompare(polygon_b, polygon_a));
 }
 
+// One quad intersects a pent with an occluded side.
+TEST(DrawPolygonSplitTest, SlimClip) {
+  std::vector<gfx::Point3F> vertices_a;
+  vertices_a.push_back(gfx::Point3F(0.0f, 10.0f, 0.0f));
+  vertices_a.push_back(gfx::Point3F(0.0f, 0.0f, 0.0f));
+  vertices_a.push_back(gfx::Point3F(10.0f, 0.0f, 0.0f));
+  vertices_a.push_back(gfx::Point3F(10.0f, 10.0f, 0.0f));
+  std::vector<gfx::Point3F> vertices_b;
+  vertices_b.push_back(gfx::Point3F(9.0f, 9.0f, 5.000f));
+  vertices_b.push_back(gfx::Point3F(1.0f, 1.0f, 0.001f));
+  vertices_b.push_back(gfx::Point3F(1.0f, 1.0f, 0.000f));
+  vertices_b.push_back(gfx::Point3F(1.002f, 1.002f, -0.005f));
+  vertices_b.push_back(gfx::Point3F(9.0f, 9.0f, -4.000f));
+
+  CREATE_NEW_DRAW_POLYGON_PTR(polygon_a, vertices_a,
+                              gfx::Vector3dF(0.0f, 0.0f, 1.0f), 0);
+  CREATE_NEW_DRAW_POLYGON_PTR(
+      polygon_b, vertices_b,
+      gfx::Vector3dF(sqrt(2) / 2, -sqrt(2) / 2, 0.000000), 1);
+
+// These are well formed, convex polygons.
+#if !defined(OS_WIN)

[enne (OOO), 2016/10/14 18:04:59]

These are well-formed polygons, except on Windows.  <_<

Can you make this work everywhere?

[flackr, 2016/10/14 18:12:32]

They're well-formed on Windows too, but defining DrawPolygon member functions
which are only compiled in the unit test doesn't work on windows (see
DrawPolygon::RecomputeNormalForTesting which is separately defined in
draw_polygon.cc on Windows). This is a tradeoff to not add or duplicate these
longer functions in draw_polygon.cc.

+  EXPECT_TRUE(polygon_a->IsPlanarForTesting());
+  EXPECT_TRUE(polygon_a->IsConvexForTesting());
+  EXPECT_TRUE(polygon_b->IsPlanarForTesting());
+  EXPECT_TRUE(polygon_b->IsConvexForTesting());
+#endif
+
+  std::unique_ptr<DrawPolygon> front_polygon;
+  std::unique_ptr<DrawPolygon> back_polygon;
+  bool is_coplanar;
+
+  polygon_a->SplitPolygon(std::move(polygon_b), &front_polygon, &back_polygon,
+                          &is_coplanar);
+
+  EXPECT_FALSE(is_coplanar);
+  EXPECT_TRUE(front_polygon != nullptr);
+  EXPECT_TRUE(back_polygon != nullptr);
+}
+
 // One quad intersects another and becomes two pieces.
 TEST(DrawPolygonSplitTest, BasicSplit) {
   std::vector<gfx::Point3F> vertices_a;
   vertices_a.push_back(gfx::Point3F(0.0f, 10.0f, 0.0f));
   vertices_a.push_back(gfx::Point3F(0.0f, 0.0f, 0.0f));
   vertices_a.push_back(gfx::Point3F(10.0f, 0.0f, 0.0f));
   vertices_a.push_back(gfx::Point3F(10.0f, 10.0f, 0.0f));
   std::vector<gfx::Point3F> vertices_b;
   vertices_b.push_back(gfx::Point3F(5.0f, 10.0f, -5.0f));
   vertices_b.push_back(gfx::Point3F(5.0f, 0.0f, -5.0f));
@@ skipping 69 matching lines @@
   test_points_b.push_back(gfx::Point3F(1.0f, 0.0f, 0.0f));
   test_points_b.push_back(gfx::Point3F(0.0f, 0.0f, 0.0f));
   test_points_b.push_back(gfx::Point3F(0.0f, 0.0f, 10.0f));
   test_points_b.push_back(gfx::Point3F(10.0f, 0.0f, 10.0f));
   test_points_b.push_back(gfx::Point3F(10.0f, 0.0f, 9.0f));
 
   ValidatePointsWithinDeltaOf(*(front_polygon.get()), test_points_a, 1e-6f);
   ValidatePointsWithinDeltaOf(*(back_polygon.get()), test_points_b, 1e-6f);
 }
 
+// In this test we cut the corner of a quad so that it creates a triangle and
+// a pentagon as a result, and then cut the pentagon.
+TEST(DrawPolygonSplitTest, DoubleSplit) {
+  std::vector<gfx::Point3F> vertices_a;
+  vertices_a.push_back(gfx::Point3F(0.0f, 0.0f, 0.0f));
+  vertices_a.push_back(gfx::Point3F(0.0f, 0.0f, 10.0f));
+  vertices_a.push_back(gfx::Point3F(10.0f, 0.0f, 10.0f));
+  vertices_a.push_back(gfx::Point3F(10.0f, 0.0f, 0.0f));
+  std::vector<gfx::Point3F> vertices_b;
+  vertices_b.push_back(gfx::Point3F(2.0f, 5.0f, 1.0f));
+  vertices_b.push_back(gfx::Point3F(2.0f, -5.0f, 1.0f));
+  vertices_b.push_back(gfx::Point3F(-1.0f, -5.0f, -2.0f));
+  vertices_b.push_back(gfx::Point3F(-1.0f, 5.0f, -2.0f));
+
+  CREATE_NEW_DRAW_POLYGON_PTR(polygon_a, vertices_a,
+                              gfx::Vector3dF(0.0f, 1.0f, 0.0f), 0);
+  CREATE_NEW_DRAW_POLYGON_PTR(polygon_b, vertices_b,
+                              gfx::Vector3dF(sqrt(2) / 2, 0.0f, -sqrt(2) / 2),
+                              1);
+
+  std::unique_ptr<DrawPolygon> front_polygon;
+  std::unique_ptr<DrawPolygon> back_polygon;
+  bool is_coplanar;
+
+  polygon_b->SplitPolygon(std::move(polygon_a), &front_polygon, &back_polygon,
+                          &is_coplanar);
+  EXPECT_FALSE(is_coplanar);
+  EXPECT_TRUE(front_polygon != nullptr);
+  EXPECT_TRUE(back_polygon != nullptr);
+
+  EXPECT_EQ(3u, front_polygon->points().size());
+  EXPECT_EQ(5u, back_polygon->points().size());
+
+  std::vector<gfx::Point3F> vertices_c;
+  vertices_c.push_back(gfx::Point3F(0.0f, 0.0f, 10.0f));
+  vertices_c.push_back(gfx::Point3F(1.0f, -0.05f, 0.0f));
+  vertices_c.push_back(gfx::Point3F(10.0f, 0.05f, 9.0f));
+
+  CREATE_NEW_DRAW_POLYGON_PTR(polygon_c, vertices_c,
+                              gfx::Vector3dF(0.0055f, -0.999f, 0.0055f), 0);
+
+  std::unique_ptr<DrawPolygon> second_front_polygon;
+  std::unique_ptr<DrawPolygon> second_back_polygon;
+
+  polygon_c->SplitPolygon(std::move(back_polygon), &second_front_polygon,
+                          &second_back_polygon, &is_coplanar);
+  EXPECT_FALSE(is_coplanar);
+  EXPECT_TRUE(second_front_polygon != nullptr);
+  EXPECT_TRUE(second_back_polygon != nullptr);
+
+  EXPECT_EQ(3u, second_front_polygon->points().size());
+  EXPECT_EQ(3u, second_back_polygon->points().size());
+}
+
 TEST(DrawPolygonTransformTest, TransformNormal) {
   std::vector<gfx::Point3F> vertices_a;
   vertices_a.push_back(gfx::Point3F(1.0f, 0.0f, 1.0f));
   vertices_a.push_back(gfx::Point3F(-1.0f, 0.0f, -1.0f));
   vertices_a.push_back(gfx::Point3F(0.0f, 1.0f, 0.0f));
   CREATE_NEW_DRAW_POLYGON(polygon_a, vertices_a,
                           gfx::Vector3dF(sqrt(2) / 2, 0.0f, -sqrt(2) / 2), 0);
   EXPECT_NORMAL(polygon_a, sqrt(2) / 2, 0.0f, -sqrt(2) / 2);
 
   gfx::Transform transform;
   transform.RotateAboutYAxis(45.0f);
   // This would transform the vertices as well, but we are transforming a
   // DrawPolygon with 0 vertices just to make sure our normal transformation
   // using the inverse tranpose matrix gives us the right result.
   polygon_a.TransformToScreenSpace(transform);
 
   // Note: We use EXPECT_FLOAT_WITHIN_EPSILON instead of EXPECT_FLOAT_EQUAL here
   // because some architectures (e.g., Arm64) employ a fused multiply-add
   // instruction which causes rounding asymmetry and reduces precision.
   // http://crbug.com/401117.
   EXPECT_NORMAL(polygon_a, 0.0f, 0.0f, -1.0f);
 }
 
 }  // namespace
 }  // namespace cc