Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 2408133007: Check the root frame pointer events as well for capture (Closed)
Patch Set: adding comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 // direction - The logical direction to scroll in. This will be converted to 248 // direction - The logical direction to scroll in. This will be converted to
249 // a physical direction for each LayoutBox we try to scroll 249 // a physical direction for each LayoutBox we try to scroll
250 // based on that box's writing mode. 250 // based on that box's writing mode.
251 // granularity - The units that the scroll delta parameter is in. 251 // granularity - The units that the scroll delta parameter is in.
252 // startNode - Optional. If provided, start chaining from the given node. 252 // startNode - Optional. If provided, start chaining from the given node.
253 // If not, use the current focus or last clicked node. 253 // If not, use the current focus or last clicked node.
254 bool logicalScroll(ScrollDirection, 254 bool logicalScroll(ScrollDirection,
255 ScrollGranularity, 255 ScrollGranularity,
256 Node* startNode = nullptr); 256 Node* startNode = nullptr);
257 257
258 bool isTouchPointerIdActiveOnFrame(int, LocalFrame*) const;
259
258 private: 260 private:
259 WebInputEventResult handleMouseMoveOrLeaveEvent( 261 WebInputEventResult handleMouseMoveOrLeaveEvent(
260 const PlatformMouseEvent&, 262 const PlatformMouseEvent&,
261 HitTestResult* hoveredNode = nullptr, 263 HitTestResult* hoveredNode = nullptr,
262 bool onlyUpdateScrollbars = false, 264 bool onlyUpdateScrollbars = false,
263 bool forceLeave = false); 265 bool forceLeave = false);
264 266
265 HitTestRequest::HitTestRequestType getHitTypeForGestureType( 267 HitTestRequest::HitTestRequestType getHitTypeForGestureType(
266 PlatformEvent::EventType); 268 PlatformEvent::EventType);
267 void applyTouchAdjustment(PlatformGestureEvent*, HitTestResult*); 269 void applyTouchAdjustment(PlatformGestureEvent*, HitTestResult*);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 void defaultArrowEventHandler(WebFocusType, KeyboardEvent*); 331 void defaultArrowEventHandler(WebFocusType, KeyboardEvent*);
330 332
331 void updateLastScrollbarUnderMouse(Scrollbar*, bool); 333 void updateLastScrollbarUnderMouse(Scrollbar*, bool);
332 334
333 WebInputEventResult handleGestureShowPress(); 335 WebInputEventResult handleGestureShowPress();
334 336
335 bool shouldTopControlsConsumeScroll(FloatSize) const; 337 bool shouldTopControlsConsumeScroll(FloatSize) const;
336 338
337 FrameHost* frameHost() const; 339 FrameHost* frameHost() const;
338 340
341 bool RootFrameTouchPointerActiveInCurrentFrame(int pointerId) const;
dtapuska 2016/10/19 00:22:29 I don't think we name functions with a capital as
Navid Zolghadr 2016/10/19 15:35:37 Done.
342
339 // NOTE: If adding a new field to this class please ensure that it is 343 // NOTE: If adding a new field to this class please ensure that it is
340 // cleared in |EventHandler::clear()|. 344 // cleared in |EventHandler::clear()|.
341 345
342 const Member<LocalFrame> m_frame; 346 const Member<LocalFrame> m_frame;
343 347
344 const Member<SelectionController> m_selectionController; 348 const Member<SelectionController> m_selectionController;
345 349
346 Timer<EventHandler> m_hoverTimer; 350 Timer<EventHandler> m_hoverTimer;
347 351
348 // TODO(rbyers): Mouse cursor update is page-wide, not per-frame. Page-wide 352 // TODO(rbyers): Mouse cursor update is page-wide, not per-frame. Page-wide
(...skipping 30 matching lines...) Expand all
379 383
380 // Set on GestureTapDown if the |pointerdown| event corresponding to the 384 // Set on GestureTapDown if the |pointerdown| event corresponding to the
381 // triggering |touchstart| event was canceled. This suppresses mouse event 385 // triggering |touchstart| event was canceled. This suppresses mouse event
382 // firing for the current gesture sequence (i.e. until next GestureTapDown). 386 // firing for the current gesture sequence (i.e. until next GestureTapDown).
383 bool m_suppressMouseEventsFromGestures; 387 bool m_suppressMouseEventsFromGestures;
384 }; 388 };
385 389
386 } // namespace blink 390 } // namespace blink
387 391
388 #endif // EventHandler_h 392 #endif // EventHandler_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/PointerEventFactory.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698