Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2408133006: SkXPS: compile under clang on win (Closed)

Created:
4 years, 2 months ago by hal.canary
Modified:
4 years, 2 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/xps/SkXPSDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/xps/SkXPSDevice.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hal.canary
PTAL
4 years, 2 months ago (2016-10-13 15:19:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408133006/1
4 years, 2 months ago (2016-10-13 15:19:46 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 2 months ago (2016-10-13 15:19:47 UTC) #10
bungeman-skia
lgtm
4 years, 2 months ago (2016-10-13 15:42:01 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:44:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a634b742320ae1c14ddb296e45569947daced9fc

Powered by Google App Engine
This is Rietveld 408576698