Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2408133005: wptserve: Do not supress 'serve' command output on Windows. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
qyearsley, jsbell
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wptserve: Do not supress 'serve' command output on Windows. BUG=623613 Committed: https://crrev.com/1a45e615bbeb1011695bca6259599ea61c26feb2 Cr-Commit-Position: refs/heads/master@{#425060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
tkent
qyearsley@ or jsbell@, would you review this trivial change please?
4 years, 2 months ago (2016-10-13 08:53:41 UTC) #2
jsbell
lgtm
4 years, 2 months ago (2016-10-13 16:09:19 UTC) #7
qyearsley
lgtm
4 years, 2 months ago (2016-10-13 16:43:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408133005/1
4 years, 2 months ago (2016-10-13 16:43:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 16:49:53 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a45e615bbeb1011695bca6259599ea61c26feb2 Cr-Commit-Position: refs/heads/master@{#425060}
4 years, 2 months ago (2016-10-13 16:52:01 UTC) #13
tkent
4 years, 2 months ago (2016-10-19 00:21:11 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2427133002/ by tkent@chromium.org.

The reason for reverting is: This diagnostic change isn't necessary any longer.
.

Powered by Google App Engine
This is Rietveld 408576698