third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js - Issue 2408133004: [DevTools] Implement Target.setDiscoverTargets method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

Issue 2408133004: [DevTools] Implement Target.setDiscoverTargets method. (Closed)

Patch Set: new fancy range-based iteration in observer list! Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

index 69f79f9899b7997a23425ed4f8885c2fb217ba63..50a740619226c924626b04841fd17e2729633573 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js

@@ -151,7 +151,7 @@ WebInspector.SubTargetsManager.prototype = {

/**

* @param {string} targetId

- _targetRemoved: function(targetId)

+ _targetDestroyed: function(targetId)

{

console.assert(this._allTargets.has(targetId));

console.assert(!this._attachedTargets.has(targetId));

@@ -239,9 +239,9 @@ WebInspector.SubTargetsDispatcher.prototype = {

* @override

* @param {string} targetId

- targetRemoved: function(targetId)

+ targetDestroyed: function(targetId)

{

- this._manager._targetRemoved(targetId);

+ this._manager._targetDestroyed(targetId);

/**

« content/browser/devtools/forwarding_agent_host.cc ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »