Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2408133002: Revert of Speedup access to global_proxy.* attributes/accessors. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Speedup access to global_proxy.* attributes/accessors. (patchset #3 id:80001 of https://codereview.chromium.org/2403003002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2406213002/ Original issue's description: > Speedup access to global_proxy.* attributes/accessors. > > Using a global proxy (e.g. 'window.f', 'w.f' or 'this.f') is considerably slower than evaluating just 'f'. This CL aims to perform the necessary checks at compile time and inline the accesses. > > This is a follow-on CL to crrev.com/2369933005: > - The initial upload is crrev.com/2369933005 + a rebase. > - The remaining issues are the fixes requested by the reviewers on that CL. > > BUG=chromium:634276 > > Committed: https://crrev.com/8f43d748272536117008aa6a1b53ea52126261c1 > Cr-Commit-Position: refs/heads/master@{#40153} TBR=jochen@chromium.org,verwaest@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:634276 Committed: https://crrev.com/16055d51b4afc82ef60319c67b8d517220ea269d Cr-Commit-Position: refs/heads/master@{#40171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -164 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 7 chunks +115 lines, -155 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Speedup access to global_proxy.* attributes/accessors.
4 years, 2 months ago (2016-10-11 12:48:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408133002/1
4 years, 2 months ago (2016-10-11 12:48:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 12:48:46 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 12:49:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16055d51b4afc82ef60319c67b8d517220ea269d
Cr-Commit-Position: refs/heads/master@{#40171}

Powered by Google App Engine
This is Rietveld 408576698