Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2408103002: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2263 matching lines...) Expand 10 before | Expand all | Expand 10 after
2274 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS); 2274 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS);
2275 SetCallPosition(expr, expr->tail_call_mode()); 2275 SetCallPosition(expr, expr->tail_call_mode());
2276 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2276 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2277 if (FLAG_trace) { 2277 if (FLAG_trace) {
2278 __ CallRuntime(Runtime::kTraceTailCall); 2278 __ CallRuntime(Runtime::kTraceTailCall);
2279 } 2279 }
2280 // Update profiling counters before the tail call since we will 2280 // Update profiling counters before the tail call since we will
2281 // not return to this function. 2281 // not return to this function.
2282 EmitProfilingCounterHandlingForReturnSequence(true); 2282 EmitProfilingCounterHandlingForReturnSequence(true);
2283 } 2283 }
2284 Handle<Code> ic = 2284 Handle<Code> code =
2285 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2285 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
2286 .code(); 2286 .code();
2287 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackICSlot()))); 2287 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackICSlot())));
2288 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize)); 2288 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));
2289 // Don't assign a type feedback id to the IC, since type feedback is provided 2289 __ call(code, RelocInfo::CODE_TARGET);
2290 // by the vector above.
2291 CallIC(ic);
2292 OperandStackDepthDecrement(arg_count + 1); 2290 OperandStackDepthDecrement(arg_count + 1);
2293 2291
2294 RecordJSReturnSite(expr); 2292 RecordJSReturnSite(expr);
2295 RestoreContext(); 2293 RestoreContext();
2296 context()->DropAndPlug(1, eax); 2294 context()->DropAndPlug(1, eax);
2297 } 2295 }
2298 2296
2299 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2297 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2300 int arg_count = expr->arguments()->length(); 2298 int arg_count = expr->arguments()->length();
2301 // Push copy of the first argument or undefined if it doesn't exist. 2299 // Push copy of the first argument or undefined if it doesn't exist.
(...skipping 1260 matching lines...) Expand 10 before | Expand all | Expand 10 after
3562 isolate->builtins()->OnStackReplacement()->entry(), 3560 isolate->builtins()->OnStackReplacement()->entry(),
3563 Assembler::target_address_at(call_target_address, unoptimized_code)); 3561 Assembler::target_address_at(call_target_address, unoptimized_code));
3564 return ON_STACK_REPLACEMENT; 3562 return ON_STACK_REPLACEMENT;
3565 } 3563 }
3566 3564
3567 3565
3568 } // namespace internal 3566 } // namespace internal
3569 } // namespace v8 3567 } // namespace v8
3570 3568
3571 #endif // V8_TARGET_ARCH_IA32 3569 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698