Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2408103002: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2364 matching lines...) Expand 10 before | Expand all | Expand 10 after
2375 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS); 2375 PrepareForBailoutForId(expr->CallId(), BailoutState::NO_REGISTERS);
2376 SetCallPosition(expr, expr->tail_call_mode()); 2376 SetCallPosition(expr, expr->tail_call_mode());
2377 if (expr->tail_call_mode() == TailCallMode::kAllow) { 2377 if (expr->tail_call_mode() == TailCallMode::kAllow) {
2378 if (FLAG_trace) { 2378 if (FLAG_trace) {
2379 __ CallRuntime(Runtime::kTraceTailCall); 2379 __ CallRuntime(Runtime::kTraceTailCall);
2380 } 2380 }
2381 // Update profiling counters before the tail call since we will 2381 // Update profiling counters before the tail call since we will
2382 // not return to this function. 2382 // not return to this function.
2383 EmitProfilingCounterHandlingForReturnSequence(true); 2383 EmitProfilingCounterHandlingForReturnSequence(true);
2384 } 2384 }
2385 Handle<Code> ic = 2385 Handle<Code> code =
2386 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode()) 2386 CodeFactory::CallIC(isolate(), arg_count, mode, expr->tail_call_mode())
2387 .code(); 2387 .code();
2388 __ mov(r3, Operand(SmiFromSlot(expr->CallFeedbackICSlot()))); 2388 __ mov(r3, Operand(SmiFromSlot(expr->CallFeedbackICSlot())));
2389 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize)); 2389 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize));
2390 // Don't assign a type feedback id to the IC, since type feedback is provided 2390 __ Call(code, RelocInfo::CODE_TARGET);
2391 // by the vector above.
2392 CallIC(ic);
2393 OperandStackDepthDecrement(arg_count + 1); 2391 OperandStackDepthDecrement(arg_count + 1);
2394 2392
2395 RecordJSReturnSite(expr); 2393 RecordJSReturnSite(expr);
2396 RestoreContext(); 2394 RestoreContext();
2397 context()->DropAndPlug(1, r0); 2395 context()->DropAndPlug(1, r0);
2398 } 2396 }
2399 2397
2400 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2398 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2401 int arg_count = expr->arguments()->length(); 2399 int arg_count = expr->arguments()->length();
2402 // r4: copy of the first argument or undefined if it doesn't exist. 2400 // r4: copy of the first argument or undefined if it doesn't exist.
(...skipping 1325 matching lines...) Expand 10 before | Expand all | Expand 10 after
3728 DCHECK(interrupt_address == 3726 DCHECK(interrupt_address ==
3729 isolate->builtins()->OnStackReplacement()->entry()); 3727 isolate->builtins()->OnStackReplacement()->entry());
3730 return ON_STACK_REPLACEMENT; 3728 return ON_STACK_REPLACEMENT;
3731 } 3729 }
3732 3730
3733 3731
3734 } // namespace internal 3732 } // namespace internal
3735 } // namespace v8 3733 } // namespace v8
3736 3734
3737 #endif // V8_TARGET_ARCH_ARM 3735 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698