Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2408093003: [heap] User size_t in GcTracer (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] User size_t in GcTracer BUG=chromium:652721 Committed: https://crrev.com/abe50f04bec339d85f331317749ff957ef85b386 Cr-Commit-Position: refs/heads/master@{#40179}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M src/heap/gc-tracer.h View 5 chunks +11 lines, -14 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 7 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
ptal
4 years, 2 months ago (2016-10-11 12:40:47 UTC) #2
Michael Lippautz
lgtm https://codereview.chromium.org/2408093003/diff/1/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (right): https://codereview.chromium.org/2408093003/diff/1/src/heap/gc-tracer.cc#newcode19 src/heap/gc-tracer.cc:19: DCHECK_GE(space->Available(), 0); nit: DCHECK_GE(holes_size + space->Waste() + space->Available(), ...
4 years, 2 months ago (2016-10-11 14:54:39 UTC) #3
ulan
On 2016/10/11 14:54:39, Michael Lippautz wrote: > lgtm > > https://codereview.chromium.org/2408093003/diff/1/src/heap/gc-tracer.cc > File src/heap/gc-tracer.cc (right): ...
4 years, 2 months ago (2016-10-11 14:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408093003/20001
4 years, 2 months ago (2016-10-11 14:57:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 15:30:50 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 15:31:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abe50f04bec339d85f331317749ff957ef85b386
Cr-Commit-Position: refs/heads/master@{#40179}

Powered by Google App Engine
This is Rietveld 408576698