Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html

Issue 2408083002: Revert of Import wpt@357b83b809e3cbc7a1805e7c3ca108a7980d782f (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html
diff --git a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html
index 94da3d020e2f6df524abe4b314b3be30fa20fa9f..c0aa1df82d28c46b0de42b74189eabf01b6585c9 100644
--- a/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html
+++ b/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html
@@ -7,7 +7,6 @@
<meta name="help" content="https://dom.spec.whatwg.org/#node">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
-<script src="../resources/custom-elements-helpers.js"></script>
<script src="./resources/reactions.js"></script>
</head>
<body>
@@ -24,9 +23,28 @@
// FIXME: Add a test for normalize()
-testCloner(function (customElement) {
- return customElement.cloneNode(false);
-}, 'cloneNode on Node');
+test(function () {
+ var element = defineNewCustomElement();
+ var instance = document.createElement(element.name);
+ instance.setAttribute('id', 'foo');
+ assert_array_equals(element.log().types(), ['constructed', 'attributeChanged']);
+ var newInstance = instance.cloneNode(false);
+ var logEntries = element.log();
+ assert_array_equals(logEntries.types(), ['constructed', 'attributeChanged']);
+ assert_equals(logEntries.log().name, 'id');
+ assert_equals(logEntries.log().oldValue, null);
+ assert_equals(logEntries.log().newValue, 'foo');
+}, 'cloneNode on Node must enqueue a attributeChanged reaction when cloning an element with an attribute');
+
+test(function () {
+ var element = defineNewCustomElement();
+ var instance = document.createElement(element.name);
+ instance.setAttribute('lang', 'en');
+ assert_array_equals(element.log().types(), ['constructed']);
+ var newInstance = instance.cloneNode(false);
+ assert_array_equals(element.log().types(), ['constructed']);
+}, 'cloneNode on Node must not enqueue a attributeChanged reaction when cloning an element with an attribute');
+
testNodeConnector(function (newContainer, customElement) {
newContainer.insertBefore(customElement, newContainer.firstChild);

Powered by Google App Engine
This is Rietveld 408576698