Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2408063002: Switch remaining scoped_openssl_types uses to BoringSSL scopers. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch remaining scoped_openssl_types uses to BoringSSL scopers. BUG=654143 Committed: https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c Cr-Commit-Position: refs/heads/master@{#424523}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -108 lines) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 3 chunks +3 lines, -4 lines 1 comment Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 3 chunks +5 lines, -6 lines 1 comment Download
M crypto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D crypto/auto_cbb.h View 1 chunk +0 lines, -35 lines 0 comments Download
D crypto/scoped_openssl_types.h View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
davidben
These are all pretty trivial changes. sgurun for android_webview tedchoc for chrome/browser/ui/android rdevlin.cronin for */extensions/* ...
4 years, 2 months ago (2016-10-11 18:58:18 UTC) #6
sgurun-gerrit only
On 2016/10/11 18:58:18, davidben wrote: > These are all pretty trivial changes. > > sgurun ...
4 years, 2 months ago (2016-10-11 20:02:52 UTC) #7
Ted C
On 2016/10/11 20:02:52, sgurun wrote: > On 2016/10/11 18:58:18, davidben wrote: > > These are ...
4 years, 2 months ago (2016-10-11 20:05:25 UTC) #8
Devlin
extensions lgtm
4 years, 2 months ago (2016-10-11 20:10:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408063002/1
4 years, 2 months ago (2016-10-11 20:11:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 20:16:53 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:19:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f165962d15779b07d42d5ecefd304c494a459f1c
Cr-Commit-Position: refs/heads/master@{#424523}

Powered by Google App Engine
This is Rietveld 408576698