Remove unnecessary keybinding logging

Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576
Committed: https://crrev.com/e28a5860367f57a4a769f84f9d4c295b5b92f869
Cr-Commit-Position: refs/heads/master@{#425058}

[Mike Wittman, 2016-10-10 22:37:26]

Description was changed from

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup for affected users.

BUG=654576
==========

to

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576
==========

[Mike Wittman, 2016-10-10 22:39:46]

wittman@chromium.org changed reviewers:
+ finnur@chromium.org

[Mike Wittman, 2016-10-10 22:39:46]

Hi Finnur, please take a look. Looks like you added this long ago in this
change: https://codereview.chromium.org/23812010

[Finnur, 2016-10-13 09:59:16]

LGTM, one nit.

https://codereview.chromium.org/2407993002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_commands_global_registry.cc (right):

https://codereview.chromium.org/2407993002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_commands_global_registry.cc:99: VLOG(0) <<
"Removing keybinding for " << command_name.c_str();
Can you remove this also, then?

[Mike Wittman, 2016-10-13 16:07:35]

Thanks!

https://codereview.chromium.org/2407993002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_commands_global_registry.cc (right):

https://codereview.chromium.org/2407993002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_commands_global_registry.cc:99: VLOG(0) <<
"Removing keybinding for " << command_name.c_str();
On 2016/10/13 09:59:16, Finnur wrote:
> Can you remove this also, then?

Done.

[Mike Wittman, 2016-10-13 16:07:47]

The CQ bit was checked by wittman@chromium.org

[Mike Wittman, 2016-10-13 16:07:47]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2407993002/#ps20001
(title: "remove additional logging statement")

[commit-bot: I haz the power, 2016-10-13 16:08:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 16:44:13]

Description was changed from

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576
==========

to

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576
==========

[commit-bot: I haz the power, 2016-10-13 16:44:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 16:47:13]

Description was changed from

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576
==========

to

==========
Remove unnecessary keybinding logging

This is logging slowing down pre-message-loop startup. The average
slowdown over the whole population is ~620μs, which is significant
considering the vast majority of users likely do not hit this code path.

BUG=654576

Committed: https://crrev.com/e28a5860367f57a4a769f84f9d4c295b5b92f869
Cr-Commit-Position: refs/heads/master@{#425058}
==========

[commit-bot: I haz the power, 2016-10-13 16:47:15]

Patchset 2 (id:??) landed as
https://crrev.com/e28a5860367f57a4a769f84f9d4c295b5b92f869
Cr-Commit-Position: refs/heads/master@{#425058}