Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL; these updated ones are.
Note that the icons are customized based on scale. Resources are taken from the designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link: https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
Committed: https://crrev.com/e8a19cea39a641c9e35ab84bb621c4246883de7b
Cr-Commit-Position: refs/heads/master@{#424253}
Description was changed from ========== Update new iOS omnibox security indicators to the correct dimensions. ...
4 years, 2 months ago
(2016-10-10 19:27:06 UTC)
#1
Description was changed from
==========
Update new iOS omnibox security indicators to the correct dimensions.
BUG=646665
==========
to
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL.
BUG=646665
==========
4 years, 2 months ago
(2016-10-10 19:35:31 UTC)
#3
sdefresne@, could you review these icon fixes?
lgarron
Description was changed from ========== Update new iOS omnibox security indicators to the correct dimensions. ...
4 years, 2 months ago
(2016-10-10 20:03:16 UTC)
#4
Description was changed from
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL.
BUG=646665
==========
to
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL;
thesee updated ones are.
Note that the icons are customized based on scale. Resources are taken from the
designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link:
https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
==========
sdefresne
lgtm but can you fix the typos in the description?
4 years, 2 months ago
(2016-10-10 21:24:26 UTC)
#5
lgtm but can you fix the typos in the description?
lgarron
Description was changed from ========== Update new iOS omnibox security indicators to the correct dimensions. ...
4 years, 2 months ago
(2016-10-10 21:30:16 UTC)
#6
Description was changed from
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL;
thesee updated ones are.
Note that the icons are customized based on scale. Resources are taken from the
designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link:
https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
==========
to
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL;
these updated ones are.
Note that the icons are customized based on scale. Resources are taken from the
designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link:
https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
==========
lgarron
Fixed.
4 years, 2 months ago
(2016-10-10 21:30:49 UTC)
#7
Fixed.
lgarron
The CQ bit was checked by lgarron@chromium.org
4 years, 2 months ago
(2016-10-10 21:30:50 UTC)
#8
4 years, 2 months ago
(2016-10-10 21:39:55 UTC)
#11
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Update new iOS omnibox security indicators to the correct dimensions. ...
4 years, 2 months ago
(2016-10-10 21:42:14 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL;
these updated ones are.
Note that the icons are customized based on scale. Resources are taken from the
designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link:
https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
==========
to
==========
Update new iOS omnibox security indicators to the correct dimensions.
The previous icons were too large, and not base-aligned with the omnibox URL;
these updated ones are.
Note that the icons are customized based on scale. Resources are taken from the
designer exports[1] and are compressed using a PNG optimizer (ImageOptim).
[1] Googler-only link:
https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU
BUG=646665
Committed: https://crrev.com/e8a19cea39a641c9e35ab84bb621c4246883de7b
Cr-Commit-Position: refs/heads/master@{#424253}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e8a19cea39a641c9e35ab84bb621c4246883de7b Cr-Commit-Position: refs/heads/master@{#424253}
4 years, 2 months ago
(2016-10-10 21:42:15 UTC)
#13
Issue 2407943002: Update new iOS omnibox security indicators to the correct dimensions.
(Closed)
Created 4 years, 2 months ago by lgarron
Modified 4 years, 2 months ago
Reviewers: sdefresne
Base URL:
Comments: 0