Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2407943002: Update new iOS omnibox security indicators to the correct dimensions. (Closed)

Created:
4 years, 2 months ago by lgarron
Modified:
4 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update new iOS omnibox security indicators to the correct dimensions. The previous icons were too large, and not base-aligned with the omnibox URL; these updated ones are. Note that the icons are customized based on scale. Resources are taken from the designer exports[1] and are compressed using a PNG optimizer (ImageOptim). [1] Googler-only link: https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XWHR0LUJzTVVpelU BUG=646665 Committed: https://crrev.com/e8a19cea39a641c9e35ab84bb621c4246883de7b Cr-Commit-Position: refs/heads/master@{#424253}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
lgarron
sdefresne@, could you review these icon fixes?
4 years, 2 months ago (2016-10-10 19:35:31 UTC) #3
sdefresne
lgtm but can you fix the typos in the description?
4 years, 2 months ago (2016-10-10 21:24:26 UTC) #5
lgarron
Fixed.
4 years, 2 months ago (2016-10-10 21:30:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407943002/1
4 years, 2 months ago (2016-10-10 21:31:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 21:39:55 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 21:42:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8a19cea39a641c9e35ab84bb621c4246883de7b
Cr-Commit-Position: refs/heads/master@{#424253}

Powered by Google App Engine
This is Rietveld 408576698