Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2407923002: Revert of [Interpreter] Collect feedback about Oddballs in Subtract Stub. (Closed)

Created:
4 years, 2 months ago by mythria
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Collect feedback about Oddballs in Subtract Stub. (patchset #2 id:20001 of https://codereview.chromium.org/2406843002/ ) Reason for revert: breaks win32-debug bot. Original issue's description: > [Interpreter] Collect feedback about Oddballs in Subtract Stub. > > BUG=v8:4280, v8:5400 > LOG=N > > Committed: https://crrev.com/d5d283b27d406486e2f8d7b44c6d2b3db4f98458 > Cr-Commit-Position: refs/heads/master@{#40124} TBR=leszeks@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:5400 Committed: https://crrev.com/853e176f29fa2cb479dd6ddfebedb00a8d5dbeea Cr-Commit-Position: refs/heads/master@{#40128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -84 lines) Patch
M src/code-stubs.cc View 5 chunks +6 lines, -60 lines 0 comments Download
M src/globals.h View 1 chunk +4 lines, -10 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 3 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mythria
Created Revert of [Interpreter] Collect feedback about Oddballs in Subtract Stub.
4 years, 2 months ago (2016-10-10 16:38:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407923002/1
4 years, 2 months ago (2016-10-10 16:38:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 16:39:05 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 16:39:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/853e176f29fa2cb479dd6ddfebedb00a8d5dbeea
Cr-Commit-Position: refs/heads/master@{#40128}

Powered by Google App Engine
This is Rietveld 408576698