Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2407913002: Stop using unittest in point_test and rectangle_test. (Closed)

Created:
4 years, 2 months ago by Bob Nystrom
Modified:
4 years, 2 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop using unittest in point_test and rectangle_test. This also makes rectangle_test strong mode clean. Alas, the test isn't passing because of another bug, but once that bug is fixed, it should. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9b6317d571466610c5fae387450d18c237de2045

Patch Set 1 #

Patch Set 2 : Fix cast in the input_sdk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -300 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/math/point_test.dart View 1 chunk +60 lines, -51 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/math/rectangle_test.dart View 1 chunk +242 lines, -237 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/math/rectangle.dart View 1 1 chunk +9 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 2 months ago (2016-10-10 16:28:23 UTC) #2
vsm
lgtm
4 years, 2 months ago (2016-10-10 16:31:01 UTC) #3
Bob Nystrom
4 years, 2 months ago (2016-10-10 18:02:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9b6317d571466610c5fae387450d18c237de2045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698