Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: media/video/capture/video_capture_types.h

Issue 24079003: Add VideoCaptureDevice::GetDeviceSupportedFormats to interface + implementation for Linux and Fake (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual rebase + changed GetDeviceSupportedFormats to static, to be called right after GetDeviceName… Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/video_capture_types.h
diff --git a/media/video/capture/video_capture_types.h b/media/video/capture/video_capture_types.h
index 1a170aaf5e7d623b102f96020d5805d04aab1680..a1246c5ca553fd3981fa2471524853032c3cc704 100644
--- a/media/video/capture/video_capture_types.h
+++ b/media/video/capture/video_capture_types.h
@@ -55,7 +55,7 @@ class MEDIA_EXPORT VideoCaptureFormat {
class MEDIA_EXPORT VideoCaptureParams : public VideoCaptureFormat {
public:
VideoCaptureParams();
-
+ // TODO(mcasas): http://crbug.com/297597, investigate if session_id is in use.
VideoCaptureSessionId session_id;
};
@@ -72,11 +72,15 @@ class MEDIA_EXPORT VideoCaptureCapability : public VideoCaptureFormat {
VideoCaptureResolutionType frame_size_type);
VideoPixelFormat color; // Desired video type.
+ // TODO(mcasas): http://crbug.com/297597, investigate if the following three
+ // attributes are in use at all.
int expected_capture_delay; // Expected delay in millisecond.
bool interlaced; // Need interlace format.
VideoCaptureSessionId session_id;
};
+typedef std::vector<VideoCaptureCapability> VideoCaptureFormats;
perkj_chrome 2013/10/13 12:12:49 VideoCaptureCapabilities? does this typedef alread
mcasas 2013/10/14 08:24:46 Yes, it exists in webrtc device_info_impl.h, but t
+
} // namespace media
#endif // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698