Remove --harmony-for-in flag which is always false

Remove --harmony-for-in flag which is always false

The ES spec has been updated to include this legacy syntax in Annex B:
https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads

R=neis@chromium.org
BUG=v8:4942
Committed: https://crrev.com/d4c4618174e88eb0635ca276c4e79e4905e9e316
Cr-Commit-Position: refs/heads/master@{#40189}

[adamk, 2016-10-10 22:40:13]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:40:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 23:05:50]

Dry run: This issue passed the CQ dry run.

[neis, 2016-10-11 08:59:59]

lgtm with comments

https://codereview.chromium.org/2407863003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2407863003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1971: ++use_counts_[v8::Isolate::kForInInitializer];
Don't you want to delete this line too? (You deleted a similar one in
parser-base.h.)

https://codereview.chromium.org/2407863003/diff/1/test/mjsunit/harmony/for-in.js
File test/mjsunit/harmony/for-in.js (left):

https://codereview.chromium.org/2407863003/diff/1/test/mjsunit/harmony/for-in...
test/mjsunit/harmony/for-in.js:9: assertThrows("for (let x = 0 in {});",
SyntaxError);
Can you move the two valid cases over to the other test file?  And maybe add one
for the var case:

let n = 0;
for (var x = n++ in {});
assertEquals(1, n);

[adamk, 2016-10-11 22:14:48]

https://codereview.chromium.org/2407863003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2407863003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1971: ++use_counts_[v8::Isolate::kForInInitializer];
On 2016/10/11 08:59:58, neis wrote:
> Don't you want to delete this line too? (You deleted a similar one in
> parser-base.h.)

The one I removed was guarded by the flag, which is why I removed it. This use
counter continues to monitor how often this path is hit in the wild, which is
something we might still be interested in (long-term, if it goes down enough, we
could try removing it from the spec again).

https://codereview.chromium.org/2407863003/diff/1/test/mjsunit/harmony/for-in.js
File test/mjsunit/harmony/for-in.js (left):

https://codereview.chromium.org/2407863003/diff/1/test/mjsunit/harmony/for-in...
test/mjsunit/harmony/for-in.js:9: assertThrows("for (let x = 0 in {});",
SyntaxError);
On 2016/10/11 08:59:58, neis wrote:
> Can you move the two valid cases over to the other test file?  And maybe add
one
> for the var case:
> 
> let n = 0;
> for (var x = n++ in {});
> assertEquals(1, n);

Added the failure cases to the existing test in mjsunit/for-in.js (I didn't add
another positive test case, since I think it covers the same stuff).

[adamk, 2016-10-11 22:14:52]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-11 22:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2407863003/#ps20001
(title: "Migrate tests")

[commit-bot: I haz the power, 2016-10-11 22:15:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:20:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-11 23:21:07]

Description was changed from

==========
Remove --harmony-for-in flag which is always false

The ES spec has been updated to include this legacy syntax in Annex B:
https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads

R=neis@chromium.org
BUG=v8:4942
==========

to

==========
Remove --harmony-for-in flag which is always false

The ES spec has been updated to include this legacy syntax in Annex B:
https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads

R=neis@chromium.org
BUG=v8:4942

Committed: https://crrev.com/d4c4618174e88eb0635ca276c4e79e4905e9e316
Cr-Commit-Position: refs/heads/master@{#40189}
==========

[commit-bot: I haz the power, 2016-10-11 23:21:08]

Patchset 2 (id:??) landed as
https://crrev.com/d4c4618174e88eb0635ca276c4e79e4905e9e316
Cr-Commit-Position: refs/heads/master@{#40189}