Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2407853002: cocoa browser: add accessible tooltip for security state (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: add accessible tooltip for security state The accessible tooltip is: "Label text. View site information, button", where the label text is either "Secure" for regular SSL sites, or the origin's EV name for EV sites. BUG=447191 Committed: https://crrev.com/78c8836bf9f6d446686e631e874bf4011d480126 Cr-Commit-Position: refs/heads/master@{#424155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
mark: ptal? :)
4 years, 2 months ago (2016-10-10 15:05:29 UTC) #3
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-10 15:09:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407853002/1
4 years, 2 months ago (2016-10-10 15:17:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 15:40:45 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 15:42:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78c8836bf9f6d446686e631e874bf4011d480126
Cr-Commit-Position: refs/heads/master@{#424155}

Powered by Google App Engine
This is Rietveld 408576698