Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 240783004: Disabling WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest (Closed)

Created:
6 years, 8 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, phoglund_chromium
Visibility:
Public.

Description

Disabling WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest since it times out and I can't reproduce locally or find any change to blame. Seems flaky and is already disabled on other platforms. TBR=vrk BUG=364418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264490

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (0 generated)
henrika (OOO until Aug 14)
The CQ bit was checked by henrika@chromium.org
6 years, 8 months ago (2014-04-17 09:00:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/240783004/1
6 years, 8 months ago (2014-04-17 09:00:53 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 09:00:53 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-17 09:00:54 UTC) #4
henrika (OOO until Aug 14)
The CQ bit was checked by henrika@chromium.org
6 years, 8 months ago (2014-04-17 09:04:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/240783004/1
6 years, 8 months ago (2014-04-17 09:04:54 UTC) #6
commit-bot: I haz the power
Change committed as 264490
6 years, 8 months ago (2014-04-17 12:37:42 UTC) #7
Ami GONE FROM CHROMIUM
https://codereview.chromium.org/240783004/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/240783004/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode220 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:220: #define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInteropTest Post-commit drive-by FYI It's always best ...
6 years, 8 months ago (2014-04-17 16:41:56 UTC) #8
henrika (OOO until Aug 14)
6 years, 8 months ago (2014-04-22 07:46:49 UTC) #9
Message was sent while issue was closed.
Sorry, forgot. I think that phoglund@ will take a look at it pretty soon.

Powered by Google App Engine
This is Rietveld 408576698