Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2407823002: [turbofan] Remember source positions when creating graph from bytecode. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remember source positions when creating graph from bytecode. R=bmeurer@chromium.org BUG=v8:5439 Committed: https://crrev.com/27228d2ffd4ca0594a8b831ca3e9810655ccd8ae Cr-Commit-Position: refs/heads/master@{#40263}

Patch Set 1 #

Patch Set 2 : Make the position iterator a local variable and add a TODO. #

Patch Set 3 : No longer mark cctest/test-cpu-profiler/TickLinesOptimized as FAIL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 5 chunks +26 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/source-position.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
neis
4 years, 2 months ago (2016-10-10 11:45:43 UTC) #1
Benedikt Meurer
LGTM from my side.
4 years, 2 months ago (2016-10-10 11:49:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407823002/40001
4 years, 2 months ago (2016-10-13 12:57:34 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 13:14:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 13:14:22 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27228d2ffd4ca0594a8b831ca3e9810655ccd8ae
Cr-Commit-Position: refs/heads/master@{#40263}

Powered by Google App Engine
This is Rietveld 408576698