Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: src/builtins/builtins-conversion.cc

Issue 2407813002: [stubs] Port StringAddStub to TF (Closed)
Patch Set: Remove stray change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | src/code-stub-assembler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-conversion.cc
diff --git a/src/builtins/builtins-conversion.cc b/src/builtins/builtins-conversion.cc
index f3cd6020a962a4cf7dfc0ca58cc64080fcf42772..9c0b5901625573a6640c915ece10d06dd81ade9a 100644
--- a/src/builtins/builtins-conversion.cc
+++ b/src/builtins/builtins-conversion.cc
@@ -183,11 +183,7 @@ void Builtins::Generate_ToString(CodeStubAssembler* assembler) {
}
assembler->Bind(&is_number);
- {
- // TODO(tebbi): inline as soon as NumberToString is in the CodeStubAssembler
- Callable callable = CodeFactory::NumberToString(assembler->isolate());
- assembler->Return(assembler->CallStub(callable, context, input));
- }
+ { assembler->Return(assembler->ToString(context, input)); }
jgruber 2016/10/13 14:10:16 Shouldn't this be NumberToString instead of ToStri
Igor Sheludko 2016/10/13 15:41:33 I guess you intended to call assembler->NumberToSt
danno 2016/10/17 14:23:26 Done.
danno 2016/10/17 14:23:26 Yes! Good catch.
assembler->Bind(&not_heap_number);
{
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | src/code-stub-assembler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698