[stubs] Port StringAddStub to TF

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/ast/ast.h"
 #include "src/bootstrapper.h"
@@ skipping 327 matching lines @@
   }
   UNREACHABLE();
   return os;
 }
 
 
 void StringAddStub::PrintBaseName(std::ostream& os) const {  // NOLINT
   os << "StringAddStub_" << flags() << "_" << pretenure_flag();
 }
 
+void StringAddStub::GenerateAssembly(CodeStubAssembler* assembler) const {
+  typedef compiler::Node Node;
+  Node* left = assembler->Parameter(Descriptor::kLeft);
+  Node* right = assembler->Parameter(Descriptor::kRight);
+  Node* context = assembler->Parameter(Descriptor::kContext);
+
+  if ((flags() & STRING_ADD_CHECK_LEFT) != 0) {
+    DCHECK((flags() & STRING_ADD_CONVERT) != 0);
+    left = assembler->ToString(context,
+                               assembler->JSReceiverToPrimitive(context, left));

[Igor Sheludko, 2016/10/13 15:41:33]

Note: we could generate a better code here if we combine these two calls (no
duplicate smi checks, no duplicate instance type loads in certain cases).

[danno, 2016/10/17 14:23:26]

Yes, but it somewhat breaks the abstraction of having nicely encapulated chunks
of functionality. How about I add a TODO and we can consider this if there is a
big performance regression or it becomes an issue at some point.

+  }
+  if ((flags() & STRING_ADD_CHECK_RIGHT) != 0) {
+    DCHECK((flags() & STRING_ADD_CONVERT) != 0);
+    right = assembler->ToString(
+        context, assembler->JSReceiverToPrimitive(context, right));
+  }
+
+  if ((flags() & STRING_ADD_CHECK_BOTH) == 0) {
+    CodeStubAssembler::AllocationFlag flags =
+        (pretenure_flag() == TENURED) ? CodeStubAssembler::kPretenured
+                                      : CodeStubAssembler::kNone;
+    assembler->Return(assembler->StringAdd(context, left, right, flags));
+  } else {
+    StringAddStub stub(isolate(), STRING_ADD_CHECK_NONE, pretenure_flag());
+    StringAddDescriptor descriptor(isolate());
+    assembler->TailCallStub(descriptor, assembler->HeapConstant(stub.GetCode()),

[Igor Sheludko, 2016/10/13 15:41:33]

I think
  Callable callable = CodeFactory::StringAdd().
  assembler->TailCallStub(callable, ...)
is better because the correct call interface descriptor will be used
automatically.

[danno, 2016/10/17 14:23:26]

Done.

+                            context, left, right);
+  }
+}
 
 InlineCacheState CompareICStub::GetICState() const {
   CompareICState::State state = Max(left(), right());
   switch (state) {
     case CompareICState::UNINITIALIZED:
       return ::v8::internal::UNINITIALIZED;
     case CompareICState::BOOLEAN:
     case CompareICState::SMI:
     case CompareICState::NUMBER:
     case CompareICState::INTERNALIZED_STRING:
@@ skipping 1798 matching lines @@
   descriptor->SetMissHandler(Runtime::kBinaryOpIC_Miss);
 }
 
 
 void BinaryOpWithAllocationSiteStub::InitializeDescriptor(
     CodeStubDescriptor* descriptor) {
   descriptor->Initialize(
       FUNCTION_ADDR(Runtime_BinaryOpIC_MissWithAllocationSite));
 }
 
-
-void StringAddStub::InitializeDescriptor(CodeStubDescriptor* descriptor) {
-  descriptor->Initialize(Runtime::FunctionForId(Runtime::kStringAdd)->entry);
-  descriptor->SetMissHandler(Runtime::kStringAdd);
-}
-
-
 void GetPropertyStub::GenerateAssembly(CodeStubAssembler* assembler) const {
   typedef compiler::Node Node;
   typedef CodeStubAssembler::Label Label;
   typedef CodeStubAssembler::Variable Variable;
 
   Label call_runtime(assembler, Label::kDeferred), return_undefined(assembler),
       end(assembler);
 
   Node* object = assembler->Parameter(0);
   Node* key = assembler->Parameter(1);
@@ skipping 850 matching lines @@
 
   if (type == MachineType::Pointer()) {
     return Representation::External();
   }
 
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8