[stubs] Port StringAddStub to TF

src/builtins/builtins-conversion.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 #include "src/code-factory.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 165 matching lines @@
 
   assembler->Bind(&not_string);
   {
     assembler->GotoUnless(
         assembler->WordEqual(input_map, assembler->HeapNumberMapConstant()),
         &not_heap_number);
     assembler->Goto(&is_number);
   }
 
   assembler->Bind(&is_number);
-  {
-    // TODO(tebbi): inline as soon as NumberToString is in the CodeStubAssembler
-    Callable callable = CodeFactory::NumberToString(assembler->isolate());
-    assembler->Return(assembler->CallStub(callable, context, input));
-  }
+  { assembler->Return(assembler->ToString(context, input)); }

[jgruber, 2016/10/13 14:10:16]

Shouldn't this be NumberToString instead of ToString? Also the brackets could be
removed.

[Igor Sheludko, 2016/10/13 15:41:33]

I guess you intended to call assembler->NumberToString() here.

[danno, 2016/10/17 14:23:26]

Done.

[danno, 2016/10/17 14:23:26]

Yes! Good catch.

 
   assembler->Bind(&not_heap_number);
   {
     assembler->GotoIf(
         assembler->Word32NotEqual(input_instance_type,
                                   assembler->Int32Constant(ODDBALL_TYPE)),
         &runtime);
     assembler->Return(
         assembler->LoadObjectField(input, Oddball::kToStringOffset));
   }
@@ skipping 276 matching lines @@
   typedef TypeofDescriptor Descriptor;
 
   Node* object = assembler->Parameter(Descriptor::kObject);
   Node* context = assembler->Parameter(Descriptor::kContext);
 
   assembler->Return(assembler->Typeof(object, context));
 }
 
 }  // namespace internal
 }  // namespace v8