Fix assertion in the parser about operator precedence.

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 27619)
+++ runtime/vm/parser.cc	(working copy)
@@ -1897,7 +1897,7 @@
       negate_result = true;
     }
 
-    ASSERT(Token::Precedence(op) >= Token::Precedence(Token::kBIT_OR));
+    ASSERT(Token::Precedence(op) >= Token::Precedence(Token::kEQ));

[Kevin Millikin (Google), 2013/09/18 15:13:21]

This is OK to fix the tests.

It's kind of annoying to assert anything about precedence or to rely
specifically on a particular operator's precedence.

I probably find that annoying because overriding operators has basically nothing
at all to do with precedence.

[hausner, 2013/09/18 15:52:37]

We are blindly calling ParseBinaryExpr() here, so we better make sure that the
operator can be handled by that function. That's what this assert is about.
Maybe you find it a bit less annoying now.


On 2013/09/18 15:13:21, kmillikin wrote:

     AstNode* other_operand = ParseBinaryExpr(Token::Precedence(op) + 1);
 
     ArgumentListNode* op_arguments = new ArgumentListNode(operator_pos);
@@ -7345,7 +7345,7 @@
 
 AstNode* Parser::ParseBinaryExpr(int min_preced) {
   TRACE_PARSER("ParseBinaryExpr");
-  ASSERT(min_preced >= 4);
+  ASSERT(min_preced >= Token::Precedence(Token::kOR));
   AstNode* left_operand = ParseUnaryExpr();
   if (left_operand->IsPrimaryNode() &&
       (left_operand->AsPrimaryNode()->IsSuper())) {