Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2407793002: Revert of [builtins] Move StringIncludes to a builtin. (Closed)

Created:
4 years, 2 months ago by petermarshall
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Move StringIncludes to a builtin. (patchset #4 id:60001 of https://codereview.chromium.org/2399423003/ ) Reason for revert: String.includes crashes when called with null or undefined as the first param Original issue's description: > [builtins] Move StringIncludes to a builtin. > > BUG=v8:5364 > > Committed: https://crrev.com/b374d719e79a5b32168c25c0cda30056f5e6e36c > Cr-Commit-Position: refs/heads/master@{#40110} TBR=franzih@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5364 Committed: https://crrev.com/407b479d23f961545ba76ac4db098a9808678069 Cr-Commit-Position: refs/heads/master@{#40118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -41 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/js/string.js View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
petermarshall
Created Revert of [builtins] Move StringIncludes to a builtin.
4 years, 2 months ago (2016-10-10 11:22:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407793002/1
4 years, 2 months ago (2016-10-10 11:23:07 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-10 11:23:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407793002/1
4 years, 2 months ago (2016-10-10 11:24:37 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-10 11:24:38 UTC) #9
Franzi
LGTM.
4 years, 2 months ago (2016-10-10 11:26:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407793002/1
4 years, 2 months ago (2016-10-10 11:27:03 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 11:27:13 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 11:27:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/407b479d23f961545ba76ac4db098a9808678069
Cr-Commit-Position: refs/heads/master@{#40118}

Powered by Google App Engine
This is Rietveld 408576698