Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2407753002: Fix crash from state management cleanup (Closed)
Patch Set: Fix state restore missed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 #include <memory> 10 #include <memory>
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 DECLARE_VIRTUAL_TRACE_WRAPPERS(); 721 DECLARE_VIRTUAL_TRACE_WRAPPERS();
722 722
723 protected: 723 protected:
724 friend class V8WebGL2RenderingContext; 724 friend class V8WebGL2RenderingContext;
725 725
726 WebGL2RenderingContextBase( 726 WebGL2RenderingContextBase(
727 HTMLCanvasElement*, 727 HTMLCanvasElement*,
728 std::unique_ptr<WebGraphicsContext3DProvider>, 728 std::unique_ptr<WebGraphicsContext3DProvider>,
729 const CanvasContextCreationAttributes& requestedAttributes); 729 const CanvasContextCreationAttributes& requestedAttributes);
730 730
731 // DrawingBuffer::Client implementation.
732 void DrawingBufferClientRestorePixelUnpackBufferBinding() override;
733
731 // Helper function to validate target and the attachment combination for 734 // Helper function to validate target and the attachment combination for
732 // getFramebufferAttachmentParameters. Generate GL error and return false if 735 // getFramebufferAttachmentParameters. Generate GL error and return false if
733 // parameters are illegal. 736 // parameters are illegal.
734 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, 737 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName,
735 GLenum target, 738 GLenum target,
736 GLenum attachment); 739 GLenum attachment);
737 740
738 bool validateClearBuffer(const char* functionName, 741 bool validateClearBuffer(const char* functionName,
739 GLenum buffer, 742 GLenum buffer,
740 GLsizei length); 743 GLsizei length);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
867 context, 870 context,
868 context->is3d() && 871 context->is3d() &&
869 WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 872 WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
870 context.is3d() && 873 context.is3d() &&
871 WebGLRenderingContextBase::getWebGLVersion(&context) >= 874 WebGLRenderingContextBase::getWebGLVersion(&context) >=
872 2); 875 2);
873 876
874 } // namespace blink 877 } // namespace blink
875 878
876 #endif 879 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698