Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2407733003: X87: [heap] New heuristics for incremental marking step size. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
Reviewers:
Weiliang, ulan, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [heap] New heuristics for incremental marking step size. port 1beb89f24cb01663843a7519921e7caf0910c760 (r39827) original commit message: This patch simplifies code for speeding up marking and removes write barrier counter. The step size is now computed based in two parts: - bytes to mark in order to keep up with allocation, - bytes to mark in order to make progress. BUG= Committed: https://crrev.com/749570ed718801445a743be61b62043da55e13a1 Cr-Commit-Position: refs/heads/master@{#40116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-10 06:24:20 UTC) #2
ulan
lgtm, thank you!
4 years, 2 months ago (2016-10-10 07:48:24 UTC) #3
Weiliang
On 2016/10/10 07:48:24, ulan wrote: > lgtm, thank you! lgtm
4 years, 2 months ago (2016-10-10 07:49:03 UTC) #4
zhengxing.li
On 2016/10/10 07:49:03, Weiliang wrote: > On 2016/10/10 07:48:24, ulan wrote: > > lgtm, thank ...
4 years, 2 months ago (2016-10-10 09:04:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407733003/1
4 years, 2 months ago (2016-10-10 09:31:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 09:54:23 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 09:54:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/749570ed718801445a743be61b62043da55e13a1
Cr-Commit-Position: refs/heads/master@{#40116}

Powered by Google App Engine
This is Rietveld 408576698