Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 2407733002: Load 200% resources in views_content_client. (Closed)

Created:
4 years, 2 months ago by tapted
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Load 200% resources in views_content_client. Currently views_examples_with_content_exe only depends on 100% resources. However, we want to test and compare sticker sheets for both 100% and 200%. Add a target //ui/resources:ui_test_pak_data_200_percent which repacks 200% versions of the 100% assets in ui_test_pak, and have views_content_client depend on it. BUG=636025 Committed: https://crrev.com/66badf758355e436ba84e8a4d44cc91e643d93be Cr-Commit-Position: refs/heads/master@{#424711}

Patch Set 1 #

Patch Set 2 : fix hiding #

Patch Set 3 : Require opt-in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M ui/resources/BUILD.gn View 1 2 3 chunks +33 lines, -6 lines 0 comments Download
M ui/views_content_client/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_main_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
tapted
Hi oshima - please take a look (note this also fixes http://crbug.com/636995, but only by ...
4 years, 2 months ago (2016-10-10 03:17:21 UTC) #17
oshima
lgtm
4 years, 2 months ago (2016-10-12 04:31:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407733002/40001
4 years, 2 months ago (2016-10-12 10:06:08 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-12 11:13:02 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 11:14:37 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66badf758355e436ba84e8a4d44cc91e643d93be
Cr-Commit-Position: refs/heads/master@{#424711}

Powered by Google App Engine
This is Rietveld 408576698