Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240773003: First pass at workspaces. (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

First pass at workspaces. Ability to create new workspaces. Run tries in a workspace, each try is added to a history of a workspace. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14265

Patch Set 1 #

Patch Set 2 : remove much code redundancy #

Patch Set 3 : clean up code #

Patch Set 4 : clean up sql in design doc. #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -112 lines) Patch
M experimental/webtry/DESIGN.md View 1 2 3 4 4 chunks +61 lines, -31 lines 0 comments Download
M experimental/webtry/css/webtry.css View 1 1 chunk +11 lines, -0 lines 0 comments Download
A experimental/webtry/js/run.js View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
M experimental/webtry/main.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/index.html View 1 2 chunks +4 lines, -56 lines 0 comments Download
M experimental/webtry/templates/recent.html View 1 1 chunk +11 lines, -13 lines 0 comments Download
A experimental/webtry/templates/titlebar.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A experimental/webtry/templates/workspace.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
M experimental/webtry/webtry.go View 1 2 3 4 11 chunks +167 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-17 13:51:03 UTC) #1
mtklein
https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md File experimental/webtry/DESIGN.md (right): https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md#newcode149 experimental/webtry/DESIGN.md:149: name CHAR(64) DEFAULT '' NOT NULL, not TEXT like ...
6 years, 8 months ago (2014-04-18 16:41:43 UTC) #2
jcgregorio
https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md File experimental/webtry/DESIGN.md (right): https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md#newcode149 experimental/webtry/DESIGN.md:149: name CHAR(64) DEFAULT '' NOT NULL, Yeah, mysql refused ...
6 years, 8 months ago (2014-04-18 16:58:23 UTC) #3
mtklein
On 2014/04/18 16:58:23, jcgregorio wrote: > https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md > File experimental/webtry/DESIGN.md (right): > > https://codereview.chromium.org/240773003/diff/50001/experimental/webtry/DESIGN.md#newcode149 > ...
6 years, 8 months ago (2014-04-18 16:59:06 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-18 17:00:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/240773003/70001
6 years, 8 months ago (2014-04-18 17:00:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:00:40 UTC) #7
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-18 17:00:41 UTC) #8
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-18 17:02:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/240773003/90001
6 years, 8 months ago (2014-04-18 17:03:05 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:03:13 UTC) #11
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-18 17:03:13 UTC) #12
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-18 17:16:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/240773003/90001
6 years, 8 months ago (2014-04-18 17:16:38 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:16:46 UTC) #15
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-18 17:16:46 UTC) #16
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-19 13:40:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/240773003/90001
6 years, 8 months ago (2014-04-19 13:40:14 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 13:55:54 UTC) #19
Message was sent while issue was closed. 
Change committed as 14265

Powered by Google App Engine
This is Rietveld 408576698