PDF: Check the loaded URL in sendScriptingMessage_().

pdf/document_loader.cc

Index: pdf/document_loader.cc
diff --git a/pdf/document_loader.cc b/pdf/document_loader.cc
index ae608eff93e6e45bb7db06517afb70a403f80da5..b124dbe8c0551a66f58564da558f279e529164e9 100644
--- a/pdf/document_loader.cc
+++ b/pdf/document_loader.cc
@@ -358,7 +358,8 @@ void DocumentLoader::DidOpen(int32_t result) {
     return;
   }
 
-  int32_t http_code = loader_.GetResponseInfo().GetStatusCode();
+  pp::URLResponseInfo response = loader_.GetResponseInfo();
+  int32_t http_code = response.GetStatusCode();
   if (http_code >= 400 && http_code < 500) {
     // Error accessing resource. 4xx error indicate subsequent requests
     // will fail too.
@@ -367,6 +368,21 @@ void DocumentLoader::DidOpen(int32_t result) {
     return;
   }
 
+  pp::Var response_url = response.GetURL();
+  std::string response_url_str;
+  if (response_url.is_string())
+    response_url_str = response_url.AsString();
+  if (response_url_str.empty())
+    return;
+
+  if (actual_url_.empty()) {
+    actual_url_ = response_url_str;

[robwu, 2016/10/09 10:49:50]

Testing for URL equality may be too strict. Checking origins ought to be
sufficient, so how about renaming |actual_url_| to |actual_origin_| and using
the following instead:

  actual_origin_ = url::Origin(GURL(response_url_str)).Serialize();

[Lei Zhang, 2016/10/11 00:11:09]

Ack. We can certainly do that if desired.

+    client_->OnGotActualURL(actual_url_);
+  } else {
+    if (actual_url_ != response_url_str)

[Lei Zhang, 2016/10/11 00:09:02]

I was wondering about this as well. Would a web server ever redirect to
different URLs / origins for different chunks of a file? For load balancing
perhaps?

[Tom Sepez, 2016/10/11 16:10:47]

Seems unlikely, but we'll find out.  Want to add a UMA stat?

[nasko, 2016/10/12 00:47:47]

Why not DumpWithoutCrashing? If it is never hit, it has no overhead. But if it
hits, I imagine you would want to know what happened.

+      return;
+  }
+
   is_multipart_ = false;
   current_chunk_size_ = 0;
   current_chunk_read_ = 0;