Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2407633002: Use new BoringSSL scopers in //components. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
Reviewers:
Peter Beverloo, eroman
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new BoringSSL scopers in //components. In doing so, switch some heap-allocated things to stack-allocated and avoid needless bouncing on refcounts with EVP_PKEY_get1_*. BUG=654143 Committed: https://crrev.com/7e7722810efc072552797165546f7f77f245c396 Cr-Commit-Position: refs/heads/master@{#424303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -140 lines) Patch
M components/gcm_driver/crypto/p256_key_util.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M components/webcrypto/algorithms/aes_cbc.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M components/webcrypto/algorithms/aes_ctr.cc View 7 chunks +12 lines, -16 lines 0 comments Download
M components/webcrypto/algorithms/aes_gcm.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/webcrypto/algorithms/aes_kw.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/webcrypto/algorithms/asymmetric_key_util.h View 5 chunks +6 lines, -5 lines 0 comments Download
M components/webcrypto/algorithms/asymmetric_key_util.cc View 8 chunks +9 lines, -10 lines 0 comments Download
M components/webcrypto/algorithms/ec.cc View 17 chunks +24 lines, -23 lines 0 comments Download
M components/webcrypto/algorithms/ecdh.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/webcrypto/algorithms/ecdsa.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M components/webcrypto/algorithms/pbkdf2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/webcrypto/algorithms/rsa.cc View 14 chunks +25 lines, -24 lines 0 comments Download
M components/webcrypto/algorithms/rsa_oaep.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/webcrypto/algorithms/rsa_sign.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M components/webcrypto/algorithms/sha.cc View 5 chunks +2 lines, -8 lines 0 comments Download
M components/webcrypto/algorithms/util.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M components/webcrypto/blink_key_handle.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/webcrypto/blink_key_handle.cc View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
davidben
eroman for webcrypto peter for gcm_driver
4 years, 2 months ago (2016-10-08 17:49:43 UTC) #6
eroman
lgtm
4 years, 2 months ago (2016-10-10 22:58:25 UTC) #7
Peter Beverloo
lgtm
4 years, 2 months ago (2016-10-10 23:26:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407633002/1
4 years, 2 months ago (2016-10-10 23:27:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:29:32 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:32:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e7722810efc072552797165546f7f77f245c396
Cr-Commit-Position: refs/heads/master@{#424303}

Powered by Google App Engine
This is Rietveld 408576698