tools/telemetry/telemetry/core/jsheap/model.py - Issue 24076016: Add JS heap snapshotting functionality to Telemetry (part 2)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/core/jsheap/model.py

Issue 24076016: Add JS heap snapshotting functionality to Telemetry (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review (nduca) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5 class JsHeapSnapshotModel(object):

6 def __init__(self, raw_data):

7 # FIXME(marja): Parse the raw data (copy the parsing code from jsleakcheck).

8 pass
marja 2013/09/16 11:12:47 I don't know why this file doesn't show up as dele I don't know why this file doesn't show up as deleted, as it should. The raw diff says: Index: tools/telemetry/telemetry/core/jsheap/model.py diff --git a/tools/telemetry/telemetry/core/jsheap/model.py b/tools/telemetry/telemetry/core/jsheap/model.py deleted file mode 100644 (Similar to __init__.py.) So I'm assuming it's a code review bug, and I'll fix this later if it goes wrong.
OLD	NEW

« no previous file with comments | « tools/telemetry/telemetry/core/jsheap/__init__.py ('k') | no next file » | no next file with comments »