Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 24076007: Unify handling of position info in AST, part 1 (Closed)

Created:
7 years, 3 months ago by rossberg
Modified:
7 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Unify handling of position info in AST, part 1 * AstNode now has a position info. * Removed various ad-hoc position infos from subclasses (most of which had it). * Position is always set with the constructor, instead of later. * Take care to use kNoPosition in the right spots, to not crash the debugger. Still to do: * Eliminate Conditional::then/else_position and WhileStatement::condition_position. * Make CaseClause a proper AstNode and eliminate its custom position. * If possible, eliminate all uses of kNoPosition. R=yangguo@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=17183

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -468 lines) Patch
M src/ast.h View 93 chunks +234 lines, -216 lines 0 comments Download
M src/ast.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/parser.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/parser.cc View 129 chunks +248 lines, -225 lines 3 comments Download
M src/rewriter.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 3 months ago (2013-09-12 14:03:38 UTC) #1
Yang
LGTM with comments. https://codereview.chromium.org/24076007/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/24076007/diff/1/src/parser.cc#newcode655 src/parser.cc:655: int beg_pos = scanner().location().beg_pos; you could ...
7 years, 2 months ago (2013-09-24 16:04:15 UTC) #2
rossberg
7 years, 2 months ago (2013-10-14 09:25:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698